Flaky wrong results when casting to numeric in SUM aggregation about crate

[proddata]

Seems to be an issue with determining scale

SELECT
    txt,
    SUM(val) AS val,
    SUM(val :: NUMERIC(10, 2)) AS val2
FROM
    t01
GROUP BY
    txt;

+-----+-----+------+
| txt | val | val2 |
+-----+-----+------+
| a   | 1.0 |  100 |
+-----+-----+------+

+-----+-----+------+
| txt | val | val2 |
+-----+-----+------+
| a   | 1.0 |  1.0 |
+-----+-----+------+

[matriv]

Fails systematically with:

    @Test
    public void test_numeric_agg() {
        execute("CREATE TABLE IF NOT EXISTS t01 (txt TEXT, val DOUBLE PRECISION)");
        execute("INSERT INTO t01 VALUES ('a', 1.0), ('a', null)");
        execute("REFRESH TABLE t01");
        execute(
            """
                SELECT
                    txt,
                SUM(val) AS val,
                SUM(val :: NUMERIC(10, 2)) AS val2
                FROM t01
                GROUP BY txt
            """);
        assertThat(response).hasRows(
            "a| 1.0| 1.0"
        );
    }

and minimum 2 data nodes. you can annotate the test class with:

@IntegTestCase.ClusterScope(numDataNodes = 2, supportsDedicatedMasters = false, numClientNodes = 0)

[romseygeek]

The assertion needs to be:

assertThat(response).hasRows(
            "a| 1.0| 1.00"
        );

at which point the test fails 50% of the time. Changing the insert statement to add a single document, INSERT INTO t01 VALUES ('a', 1.0), also makes no difference. So it looks as though this is explicitly something to do with how the cast statement gets moved around between nodes.

[matriv]

Yep, from a quick debug, I saw that NumericType is streamed with null scale and precision, so the write/read value doesn't work correctly afterwards.

[romseygeek]

I think the bug is somewhere in SignatureBinder - even if a type with parameters gets passed in to bind() then the output BoundSignature has no parameters on its return type.

[romseygeek]

Thanks a lot for reporting @proddata! This issue has been fixed and will be available with the next hotfix release