Coder Social home page Coder Social logo

Comments (8)

amotl avatar amotl commented on June 27, 2024 1
  1. I created #295, crate/crate-tutorials#70 and crate/crate-jdbc#346 in order to work towards this goal.
  2. I believe the dependencies on crate and croud will not do any harm.
  3. Would leaving project-specific dependencies like sphinx-csv-filter for crate or sphinx-argparse for croud do any harm to this plan?

from crate-docs-theme.

nomicode avatar nomicode commented on June 27, 2024 1
  1. sweet!! thanks so much
  2. which dependencies? (i.e., what file or files are you referencing?)
  3. yeah I think that's fine. should be no problem to leave those project-specific deps in there

from crate-docs-theme.

amotl avatar amotl commented on June 27, 2024 1

@norosa: Do you believe we can close this ticket or is there some more work to do which I might be missing?

from crate-docs-theme.

nomicode avatar nomicode commented on June 27, 2024

@amotl take a look and let me know what you think. I'm happy to create the PRs and do the work to fix this issue. but I also thought you might like to take a shot? (i.e., to share knowledge/experience)

from crate-docs-theme.

amotl avatar amotl commented on June 27, 2024

The crate-docs-theme should specify all requirements in the setup.py file and the Sphinx project-specific docs/requirements.txt file should only list a single dependency: crate-docs-theme (not pinned to any version, so the latest is always used).

I second this, let's make [1] the single source of truth. Shall we explictly say sphinx>=3.5.4,5 in setup.py then in order to retain the flexibility to evaluate it on Sphinx 4?

[1] https://github.com/crate/crate-docs-theme/blob/main/setup.py

from crate-docs-theme.

amotl avatar amotl commented on June 27, 2024

In this context, I would also like to reference crate/crate-docs#52.

from crate-docs-theme.

amotl avatar amotl commented on June 27, 2024
  1. which dependencies? (i.e., what file or files are you referencing?)

Yeah, I actually meant those referenced at 3., apart from crate-docs-theme, at:

[2a] https://github.com/crate/crate/blob/master/docs/requirements.txt
[2b] https://github.com/crate/croud/blob/master/docs/requirements.txt

All set!

from crate-docs-theme.

nomicode avatar nomicode commented on June 27, 2024

@amotl thanks for all the work!

from crate-docs-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.