Bug in read_timeout method, "eating" the initial mark duration and producing result different from Arduino... about irremoteesp8266

[markszabo]

Thank you for the bug report. For me, and for others the library way working the original way, so it's an interesting issue to investigate. As I understood right now it saves the constant 20 instead of (now - start) / USECPERTICK + 1 when irparams.rcvstate == STATE_IDLE. Can you please send a pull request, so I can review and test your code?

[Nca78]

I kept the adding of constant 20 also.
I don't know how to make a pull request at the moment, I'm all new to github and never used git before, please leave me a little time to learn :)
I will provide you some examples also if you want.

[crankyoldgit]

Just chasing up this. If you don't know how to a pull request, can you send us a 'diff' from the current source code to your version that encompases your changes?

[roidayan]

I'm following this as well. Wouldn't the first mark be in your case a constant 1 ? As start and now would be the same? Is that what makes the difference?

[roidayan]

sorry my mistake. start is 0 first time but now will be the current micros. if we'll use the calc also for when state is idle then we'll get different result for the first item in rawbuf each time we reset to idle state. that's the reason for the constant for first item. Now sure why constant 20 was chosen.

[crankyoldgit]

Can this issue be closed now?

[crankyoldgit]

Marking this issue closed. If you disagree, please re-open.