Open to PR for Create React App PWA offline fallback page only? about pwa

[jeffposnick]

It's definitely a valid use case, but at the same time, I don't think we can commit too many different alternative service workers to this repo without it being confusing for developers.

The general philosophy behind what we have checked in as part of this template is to match the behavior implemented in the previous c-r-a service worker by default (making it easier for existing users to transition to this), but at the same time, give developers control over implementing something like the code you just shared if they want to.

So, my approach would be not to check in the code for an offline fallback page. Thank you, though!

[sidonaldson]

ah shame. I respectfully disagree. I don't think there can be any confusion. One is for serving a single static offline page and the other is true PWA offline caching.

[jeffposnick]

By the way, I'd definitely encourage you to publish your desired template to npm! You can follow the steps at https://create-react-app.dev/docs/custom-templates/ and then developers who find your template can use it to get the starting point that you describe.

I just don't think that creating multiple starting points in this repo makes the most sense.