Comments (33)
Chris won't allow it for ASIO.
For zstd, I can ask, and I shall.
from hunter.
I'm currently negotiating with the zstd maintainers for them to directly support hunter. So far it goes well.
I'll hopefully push ASIO later today. Thanks for your help.
from hunter.
zstd accepted the PR, so it's ready to go. I've subscribed to PR #95 so I'll see when it's ready. Meanwhile I should be able to PR ASIO soon.
from hunter.
Already fixed in the PR at cpp-pm/asio#3
from hunter.
could you try to bring you cmake specific changes upstream?
from hunter.
from hunter.
FYI we do still fork packages if needed, itβs just done in the cpp-pm org. Let us know if you need one
from hunter.
You'll definitely need one for ASIO.
from hunter.
@ned14 New forks here:
https://github.com/cpp-pm/zstd
https://github.com/cpp-pm/asio
Added you to the packages team also. Please send your PRs against the hunter-* branches I made there.
from hunter.
@rbsheth Sorry, you've used the wrong base for the hunter-* branch. It ought to be https://github.com/cpp-pm/asio/releases/tag/asio-1-12-2 which is the latest stable release. Can you redo the branch against that release tag please?
Also, with old cmake hunter, the branch names in the packages directory were named after the release e.g. v0.5-p0. Has the policy on this changed? If so, should I ignore the branch naming conventions specified by https://docs.hunter.sh/en/latest/creating-new/create/cmake.html?
from hunter.
hunterisation zstd PR has been submitted to facebook/zstd#1924
Can hunter directly use repos without a CMakeLists.txt in their base directory? It would be a shame to have to fork zstd purely and exclusively just to stick a dummy CMakeLists.txt in its root.
from hunter.
We could try to add that functionality to hunter
Something like the subdirectory feature for git repos
from hunter.
@ned14 Fixed: https://github.com/cpp-pm/asio
I think the branches were just the version and the releases had the -pX
suffixes.
from hunter.
@ned14 for zstd you can use hunter_source_subdir()
when the PR is merged
from hunter.
@ned14 #95 was merged and released in https://github.com/cpp-pm/hunter/releases/tag/v0.23.236, looking forward to your PRs!
from hunter.
I've got an ASIO PR ready, just was awaiting the SHA. I should push it soon.
from hunter.
What's the point of hunter-testing when PRs against hunter are CI checked?
Also the advice to use Appveyor doesn't work, due to lack of an appveyor.yml file in the root of hunter. I don't know why you don't have one of those.
from hunter.
PRs against hunter check the consistency of the hunter package declaration. They don't check if the packages themselves build successfully. The packages themselves are tested at hunter-testing
The process is documented here https://docs.hunter.sh/en/latest/creating-new/create/cmake.html
The cpp-pm guys are working on simplifying this process (see #9 and #28 for example). Input on this is highly appreciated
from hunter.
The current new package add process is quite confusing for the uninitiated, but I am making progress:
Is it okay to remove whole chunks of CI testing? Specifically, the mingw CI tests, ASIO doesn't officially support mingw, and there's a header only target for those folk in any case.
from hunter.
remove whole chunks of CI testing?
yes, just add a comment on why the chunk was commented out and add a link to a failing ci-job showing the error. For example: https://github.com/ingenue/hunter/blob/pkg.ceres-solver/appveyor.yml#L32
I'd recommend looking into why gcc and clang are failing. It looks like pthreads
is missing, as it fails at the linking stage
https://travis-ci.org/ned14/hunter-testing/jobs/624616633#L1009
/home/travis/build/ned14/hunter-testing/_testing/Hunter/_Base/79224c5/239e635/f550390/Install/lib/libasio_shared.so: undefined reference to `pthread_create'
from hunter.
@ned14 Released: https://github.com/cpp-pm/asio/releases/tag/v1.12.2-8d6df7b-p1
from hunter.
Ok PR is opened for hunter-testing cpp-pm/hunter-testing#20
I'm a bit confused now what happens next for #101. Do I have to do anything, or does what I PRed to hunter-testing auto-migrate over to hunter?
from hunter.
@ned14 First, we merge this PR. Then, I update pkg.template
with the latest master and cut a branch pkg.asio
. Then, your testing PR is merged into that branch.
As such, you should update this PR #101 with the -p1
release.
from hunter.
As such, you should update this PR #101 with the -p1 release.
Just to be clear, PR #101 should be updated with the -p1 release, but without the changes to travis and appveyor right? To be absolutely clear, everything in hunter-testing apart from those two files?
from hunter.
That's right! I know it is confusing, but that's how the system works right now.
from hunter.
-p1 is pushed to PR #101
from hunter.
@ned14 Thanks, couple comments on #101 and then I can merge
from hunter.
@ned14 #101 merged, released here: https://github.com/cpp-pm/hunter/releases/tag/v0.23.237
from hunter.
Given:
https://ci.appveyor.com/project/ned14/hunter-testing/builds/29599780/job/wkuw7nx1mdirnh25
... could someone have a look at https://github.com/ned14/hunter-testing/blob/pkg.zstd/cmake/projects/zstd/hunter.cmake and tell me what I'm doing wrong with the new source subdir facility?
from hunter.
I'm sorry, I goofed up the example in the documentation
you need to have another include to hunter_source_dir
hunter_source_subdir
and then use the command
hunter_source_subdir(
zstd
SOURCE_SUBDIR
"build/cmake")
edit: hunter_source_dir
--> hunter_source_subdir()
from hunter.
I tried that:
https://github.com/ned14/hunter-testing/blob/pkg.zstd/cmake/projects/zstd/hunter.cmake
And https://ci.appveyor.com/project/ned14/hunter-testing/build/job/xvp6go8qdvnf5ve2 complains about no such include file.
from hunter.
from hunter.
zstd just in time for Christmas!
from hunter.
Related Issues (20)
- /usr/bin/ld: /home/sahoo/.hunter/_Base/cb0ea1f/a3a48bb/b64ffe3/Install/lib/libz.a(zutil.c.o): relocation R_X86_64_PC32 against symbol `z_errmsg' can not be used when making a shared object; recompile with -fPIC HOT 12
- unittest hunter_setup_msvc fails because of ARM64 change HOT 9
- reeenable cmake hunter unittests to run in CI
- Doc - First step points to ruslo/hunter/wiki which does not exist HOT 1
- Missing OpenSSL 3.x IMPORTED Targets Crypto and SSL HOT 2
- cmake has now deprecated support for versions prior to 3.5 HOT 5
- hunter_protected_sources doesn't seem to be working with custom packages
- Update "imgui" package HOT 2
- OpenCV force push access rights HOT 1
- GitHub Actions macos-10.15 runner deprecated and removed by 2022-08-30
- OpenSSL v3+ version number not reporting correctly in CMake
- MingW builds broken in CI
- Add glog v0.6.0 version
- Should Hunter Boost move to USE_CONFIG_FROM_BOOST ON as default? HOT 1
- CMake Dependency Providers
- cmake 3.28 breaks universal 2 hunter builds with Xcode generator HOT 2
- freetype package causes error with CMake 3.28 HOT 2
- Update thrift version to latest
- Update curl to 8.5.0 HOT 6
- Update ZLIB to v1.3.1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hunter.