Disable Hunter per default about hunter

[bkotzz]

(maybe they use a system package manager like apt get, maybe another c/c++ package manager like Conan, maybe they use submodules and build deps from source, etc)

I never ever recommend that, that means that identical code isn't being compiled and used in all locations, you get non-reproducible builds and you lose a lot of LTO. A nice thing about hunter is it works with anything else as well.

Whether you, I or anyone else recommends it or not, lots projects do use those methods. The hunter_enabled flag let’s hunter coexist with those methods in projects that don’t want to change for whatever reason.

[Bjoe]

May I ask, why you are not add a HUNTER_ENABLED option with a default value NO in your project like I did

cmake_minimum_required(VERSION 3.2.0)

option(HUNTER_ENABLED "Enable Hunter package manager" NO)
include("cmake/HunterGate.cmake")
HunterGate(
    URL "https://github.co.............."
    SHA1 "....................."
    LOCAL
....
)

See https://github.com/pocoproject/poco/blob/f74be1d9e50a5d95c7758bb4bb89d888f54b4e52/CMakeLists.txt

To change this behaviour in hunter now means globally, will effect all users/builds/what ever!

[NeroBurner]

that's exactly what I did, and what (IMHO) every developer does when he/she shares a project with other developers. Why require every programmer to add the option override to all the projects?

[OvermindDL1]

Most of us prefer it to default to YES is why I would imagine. ^.^

[bkotzz]

I’m not sure I understand the motive here. That flag mostly exists for projects that already have another way to download/build their dependencies (maybe they use a system package manager like apt get, maybe another c/c++ package manager like Conan, maybe they use submodules and build deps from source, etc). It’s useful when contributing to upstream projects, to convince them to support hunter without needing hunter.

But there are also lots of projects that only use hunter, or use hunter by default, and this change would break their build until they set the option back on.

That’s a pretty invasive change. I’d only consider this if a fair amount of people are interested

[OvermindDL1]

(maybe they use a system package manager like apt get, maybe another c/c++ package manager like Conan, maybe they use submodules and build deps from source, etc)

I never ever recommend that, that means that identical code isn't being compiled and used in all locations, you get non-reproducible builds and you lose a lot of LTO. A nice thing about hunter is it works with anything else as well.

[rbsheth]

Most usage of HUNTER_ENABLED is in third-party projects that do not use Hunter but accept our modifications to support their package. To default it to disabled is counter-intuitive behavior, especially for new users. You can always set the option in your project if you want it off. 😄