Add "optick" package about hunter

[NukeBird]

Brofiler has been renamed into Optick starting from v1.2.0.

[bkotzz]

Unless you need to use this with the Vulkan sdk it looks like this package doesn’t have any dependencies, so it shouldn’t be too hard to pull in, but it will need some cmake changes. Are you looking for a fork to make these changes on?

[NukeBird]

I don't really sure what should be patched, the only dependency I can see here is pthread (for linux)...

[NukeBird]

Please tell me what can I do and I will try my best

[rbsheth]

@NukeBird Please remove things that toolchains should be taking care of, such as C++ standards and certain compiler flags. For example, this line should be removed/commented: https://github.com/bombomby/optick/blob/master/CMakeLists.txt#L6

[rbsheth]

Fork created: https://github.com/cpp-pm/optick

[NukeBird]

Can I assume that optick will be always a static library?

they're saying

Basic Integration (one line of code)
Copy 'src' folder from the repository or latest release to your game project
Add OPTICK_FRAME("MainThread"); macro to the main loop of your game and #include "optick.h" header
...

and when OPTICK_ENABLED is OFF CMakeLists making just a STATIC library, otherwise - shared

The only thing should be modified: USE_OPTICK=1 instead of USE_OPTICK=0 because of optick.config.h file

Also. Can I assume that OPTICK_ENABLE_GPU_D3D12 and OPTICK_ENABLE_GPU_VULKAN are always OFF? If no, what can we do?

[rbsheth]

Well, it seems that if you want Optick to be used, it is currently only available as a SHARED library: https://github.com/bombomby/optick/blob/master/CMakeLists.txt#L45

You can change that to STATIC.

Can we not link against Optick and then leave it to the consuming application to set USE_OPTICK appropriately? That seems like the correct method. In which case, you should always build the library (not the dummy version) in the Optick Hunter package.

One can pass the D3D12 or VULKAN flags in hunter_cmake_args or in hunter_config. If those code paths are important, we should support them.

[NukeBird]

oh, with default values it makes a lot of sense now
yes, I would love to switch SHARED to STATIC

gonna make a pull request to the fork repository soon

[NukeBird]

cpp-pm/optick#1