Coder Social home page Coder Social logo

Comments (7)

bkotzz avatar bkotzz commented on July 24, 2024

Thank you for reporting this. Would you like to make a PR to raise the minimum version requirement?

from hunter.

nasosi avatar nasosi commented on July 24, 2024

There are a couple of places that the requirement may be applied:

  1. Hunter wide: This would be fairly easy and probably require changing:
  • HunterGate check for minimum requirement
  • Relevant documentation
  1. On a per package base. Currently only zlib, png and freetype are affected.

Issue with 1: Moving to a cmake version that is about 1.5 years old may make people unhappy.
Issue with 2: Need to manage cmake version requirement on a per package basis.

I think (2) is more proper for now. Maybe backlog (1) for like 2 years from now.

I will go with (2) if there are no objections.

Also is https://github.com/hunter-packages the repository for updating patched packages?

from hunter.

rbsheth avatar rbsheth commented on July 24, 2024

Okay, seems reasonable. https://github.com/cpp-pm is the new repository for updating packages - let us know which package forks to copy from hunter-packages and we'll do it.

from hunter.

nasosi avatar nasosi commented on July 24, 2024

Ok
So it is: zlib, png and freetype.
Can you also copy over bzip2 that has another minor issue?
-N

from hunter.

rbsheth avatar rbsheth commented on July 24, 2024

@nasosi Done!

https://github.com/cpp-pm/zlib
https://github.com/cpp-pm/libpng
https://github.com/cpp-pm/freetype
https://github.com/cpp-pm/bzip2

from hunter.

cristianadam avatar cristianadam commented on July 24, 2024

The reason for the aliases is the FindModule packages naming scheme from upstream CMake. I don't know how many FindModule packages, from the ~150 that CMake has, have target names, have counterparts in cpp-pm, with different target names.

See https://gitlab.kitware.com/cmake/cmake/issues/19287 for more information.

from hunter.

caseymcc avatar caseymcc commented on July 24, 2024

Sorry just now running into this issue so coming in late. Considering the default on Ubuntu 18.04 is cmake 3.10.3, why don't we just check the version of cmake and only use the alias if it 3.11 or higher? Anyone using anything lower will just have to use the imported name.

from hunter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.