Comments (7)
Thank you for reporting this. Would you like to make a PR to raise the minimum version requirement?
from hunter.
There are a couple of places that the requirement may be applied:
- Hunter wide: This would be fairly easy and probably require changing:
- HunterGate check for minimum requirement
- Relevant documentation
- On a per package base. Currently only zlib, png and freetype are affected.
Issue with 1: Moving to a cmake version that is about 1.5 years old may make people unhappy.
Issue with 2: Need to manage cmake version requirement on a per package basis.
I think (2) is more proper for now. Maybe backlog (1) for like 2 years from now.
I will go with (2) if there are no objections.
Also is https://github.com/hunter-packages the repository for updating patched packages?
from hunter.
Okay, seems reasonable. https://github.com/cpp-pm is the new repository for updating packages - let us know which package forks to copy from hunter-packages and we'll do it.
from hunter.
Ok
So it is: zlib, png and freetype.
Can you also copy over bzip2 that has another minor issue?
-N
from hunter.
@nasosi Done!
https://github.com/cpp-pm/zlib
https://github.com/cpp-pm/libpng
https://github.com/cpp-pm/freetype
https://github.com/cpp-pm/bzip2
from hunter.
The reason for the aliases is the FindModule packages naming scheme from upstream CMake. I don't know how many FindModule packages, from the ~150 that CMake has, have target names, have counterparts in cpp-pm, with different target names.
See https://gitlab.kitware.com/cmake/cmake/issues/19287 for more information.
from hunter.
Sorry just now running into this issue so coming in late. Considering the default on Ubuntu 18.04 is cmake 3.10.3, why don't we just check the version of cmake and only use the alias if it 3.11 or higher? Anyone using anything lower will just have to use the imported name.
from hunter.
Related Issues (20)
- Add "tensorflow-lite" package HOT 1
- fatal error C1083: Cannot open include file: 'json/json.h': No such file or directory HOT 4
- [BUG] cmake hangs on hunter_unpack_directory HOT 1
- Support for OpenSSL 3.x HOT 3
- missing SHA1 details in v0.24.16 release note HOT 1
- Pass build options to boost HOT 3
- /usr/bin/ld: /home/sahoo/.hunter/_Base/cb0ea1f/a3a48bb/b64ffe3/Install/lib/libz.a(zutil.c.o): relocation R_X86_64_PC32 against symbol `z_errmsg' can not be used when making a shared object; recompile with -fPIC HOT 12
- unittest hunter_setup_msvc fails because of ARM64 change HOT 9
- reeenable cmake hunter unittests to run in CI
- Doc - First step points to ruslo/hunter/wiki which does not exist HOT 1
- Missing OpenSSL 3.x IMPORTED Targets Crypto and SSL HOT 2
- cmake has now deprecated support for versions prior to 3.5 HOT 5
- hunter_protected_sources doesn't seem to be working with custom packages
- Update "imgui" package HOT 2
- OpenCV force push access rights HOT 1
- GitHub Actions macos-10.15 runner deprecated and removed by 2022-08-30
- OpenSSL v3+ version number not reporting correctly in CMake
- MingW builds broken in CI
- Add glog v0.6.0 version
- Should Hunter Boost move to USE_CONFIG_FROM_BOOST ON as default? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hunter.