Add hdf5 package about hunter

[bkotzz]

It’s up to you, but for stability reasons you probably want to stick to a formal release, unless you need the latest code for some reason. Also makes it easier for people to know which versions we have in hunter, versus a commit hash

[bkotzz]

Sounds good. The changes to hunterize are very minimal - are you interested in trying to get these merged upstream, or would you like a fork to be created in cpp-pm?

[ThomasGuerneve]

I was initially thinking of forking it in cpp-pm but happy to do a pull request upstream (before / in parallel?) to see if they are interested in adopting hunter :)

[bkotzz]

Don’t worry about it too much. We can make you a fork in cpp-pm

[bkotzz]

https://github.com/cpp-pm/hdf5 Let us know if you are blocked on anything

[ThomasGuerneve]

Thanks a lot, I'll apply the patch very soon and will let you know once it's done, I've built it on both linux & windows, do you guys have already set up a CI or anything similar to do a pre-release check?

[bkotzz]

The current testing model is pretty ugly, but essentially every package has a branch here https://github.com/cpp-pm/hunter-testing/branches, with modifications to just the Travis and appveyor build paths, so that just the specific package is built on that branch. To run the builds, you essentially just push a commit with the Travis/appveyor changes on top of your PR ones

[ThomasGuerneve]

Thanks!
For the patch, I previously patched the latest tag 1_10_5, would you rather patch develop (master seems pretty outdated, their branching is a bit of a mess...) or should I stick to the last release 1_10_5?

[ThomasGuerneve]

Made the pull request in cpp-pm/hdf5.
I'm not familiar with travis files but if I understand correctly, all I need to do then is to amend pkg.hdf5 with up-to-date toolchains and once pushed it will run on the CI? Now the point that 's unclear to me is where is the branched to be build (the one of the pull request) specified?

[bkotzz]

The CI process is quite manual. The pkg.hd5 branch is really there just to track the state of testing for that package. To run the tests, you need to merge the pkg.hd5 and your hunter branch together, and push, and wait for the tests to run. It’s quite confusing - let me know if that makes sense

[ThomasGuerneve]

Updated hdf5 & released in: https://github.com/cpp-pm/hdf5/archive/1.10.5-hp5.tar.gz
hunter-testing (PR ) builds on:

• linux & OS X: https://travis-ci.com/ThomasGuerneve/hunter-testing/builds/132955116
• windows: https://ci.appveyor.com/project/ThomasGuerneve/hunter-testing/builds/28283314