Coder Social home page Coder Social logo

Comments (10)

ftrofin avatar ftrofin commented on July 18, 2024

I have a PR for this but I don't have access to this repo. Can you please give me access so I can create the PR?

from python-pathspec.

ftrofin avatar ftrofin commented on July 18, 2024

@cpburnz Caleb?

from python-pathspec.

cpburnz avatar cpburnz commented on July 18, 2024

@ftrofin You don't need direct access to create a pull request. Just fork the project, commit your changes there, then submit a pull request.

I think you're right that it's a bug. In my experience most programs treat symlinks as regular files if they're not resolving the target. Git, in particular, I think treats symlinks as files regardless if they point to a file or folder.

from python-pathspec.

ftrofin avatar ftrofin commented on July 18, 2024

I tried that. I cloned (using https), created a branch named 'issue_31' and tried to push it back:
$ git push --set-upstream origin issue_31
remote: Permission to cpburnz/python-path-specification.git denied to ftrofin.

from python-pathspec.

cpburnz avatar cpburnz commented on July 18, 2024

@ftrofin Are you familiar with how to fork and make pull requests on Github? On Github you have to use the web interface to perform those actions, not directly using git.

from python-pathspec.

ftrofin avatar ftrofin commented on July 18, 2024

I didn't have to do this to repos I don't own. Here is the change, very simple, can you please apply it? Thanks!

image

from python-pathspec.

cpburnz avatar cpburnz commented on July 18, 2024

@ftrofin I've implemented this on the master branch.

from python-pathspec.

ftrofin avatar ftrofin commented on July 18, 2024

Thank you Caleb. Any idea when you're going to make a new release with the latest changes/fixes?

from python-pathspec.

cpburnz avatar cpburnz commented on July 18, 2024

@ftrofin I'll be able to get to it this coming weekend.

from python-pathspec.

cpburnz avatar cpburnz commented on July 18, 2024

v0.8.0 has been released which supports symlinks.

from python-pathspec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.