Fail to match directory about python-pathspec

[cpburnz]

I'm closing this due to inactivity. If you're still interested in this issue, please comment.

[cpburnz]

@ant31

Just in case this wasn't a typo when you were writing your question, the PathSpec.from_lines() method should be given a list (or some iterable) of strings for the lines, not a string directly.

The problem is the pattern cargo/ should match that directory, and any files underneath it, but not a file named cargo. By supplying the path cargo it's interpreted as being a file and thus it is not matched which is consistent with how .gitignore works to my understanding.

E.g., If you have the directory structure:

cargo/
cargo/a

A .gitignore of:

cargo/

git will ignore the cargo directory.

However, if you have just the file:

cargo

git will not ignore the cargo file.

So, to get around this the solution would be to append a / to the directory paths. I.e.,

>>> spec = pathspec.PathSpec.from_lines('gitwildmatch', ['cargo/'])
>>> spec.match_file('cargo')
False
>>> spec.match_file('cargo/')
True

Currently, the PathSpec.match_tree() method only considers files. I could extend it with an optional argument to also consider directories if you're using that method.

[cpburnz]

@ant31 Or are you trying to ignore cargo/? If that's the case, I think you want something more like:

>>> patterns = ['**', '!cargo/']
>>> spec = pathspec.PathSpec.from_lines('gitwildmatch', patterns)
>>> spec.match_file('cargo')
True
>>> spec.match_file('cargo/a')
False