"ld: unknown option: -O1" when compiling on macOS about cparse

[sandszhouSZ]

yes, when delete it, the code could compile successfully, but the demo could not run successfully

[VinGarcia]

Hello @ianhinder and @sandszhouSZ sorry for the late reply, yes I think we can fix this in the Makefile, about the -O flag at link time, it is indeed a valid argument in Linux:

Running man ld:

       -O level
           If level is a numeric values greater than zero ld optimizes the output.  This might take significantly longer and therefore probably should only be
           enabled for the final binary.  At the moment this option only affects ELF shared library generation.  Future releases of the linker may make more use
           of this option.  Also currently there is no difference in the linker's behaviour for different non-zero values of this option.  Again this may change
           with future releases.

I will create a PR conditioning this -O1 to Linux , about the -O3 used with g++, is this one also causing problems on macOS?

[VinGarcia]

So I wrote the PR, can you guys test it to see if it is working on your environment, since I don't have a macOS for testing it.

#87

[VinGarcia]

@ianhinder and @sandszhouSZ can you guys help me test the PR #87 ? If it works I can merge it.

[VinGarcia]

Since no one answered I will just merge it and if there are any problems I will have to wait for someone that uses Mac to open a ticket.

[VinGarcia]

Done.