Modal makes the window scroll to top about cozy-ui

[GoOz]

That's odd… the modal container has a position: fixed now. Are you sure you're using the last release of Cozy-UI and that the link/button that opens up the modal doesn't have an anchor as href ? Both could explain it.

[lespacedunmatin]

Settings use cozy-ui 3.0.0beta18 (see https://github.com/cozy/cozy-settings/blob/master/package.json#L83).

[GoOz]

Indeed, I can reproduce. I can't see why but it definitely needs a deeper investigation.

[enguerran]

I did not test the code on my own, but as far as I know the content may scroll up because of a preact render. If the DOM is refreshed, the view will be repaint.
It won't be related to the modal, but to the DOM update after the modal call.

[GoOz]

@enguerran I feared that but wasn't sure. That sucks. But i'll take a look later.

[y-lohse]

I've been thinking about this as we keep having this problem. I wonder if we shound't ditch the myCondition && <Component /> approach, and do something like <Component visible={myCondition} />. Then of course the component has to handle that flag, but at least the repaint won't affect anything else, right?

[GoOz]

@y-lohse You got me there, you're sure this is the problem or you guess it is?

[y-lohse]

No, just based on what @enguerran says. We'd have to confirm it, but yeah, it sounds very likely.

[GoOz]

Ok then, I'll let someone more "javascripty" than me take this one. 😄

[GoOz]

I can't reproduce it anymore, did we just fixed by accident? Maybe the new modal fixed it.

Any thought on this @y-lohse @ptbrowne ?

[ptbrowne]

I never saw this bug with the Modal component, I think we can close.

[ptbrowne]

@y-lohse please reopen if you have seen this issue ;)