Comments (12)
Thank for the question, it will make things clearer.
Is the fact the PO has to make functional comment within the issue rather than within the PR itself an uneeded overhead?
I think not. The PO is not really interested in the technical discussion. He cares about the result. His concern with the technic is mostly related to delaying due to technical problems.
Do you think the PO shouldn't review a PR from a technical point of view?
No, his role is to be sure that the development matches the requirements (that it works well).
What about the PR status. If the PO doesn't do the merge, does he add a tag that say "it's okay to merge that PR for me" like functional ok?
You're right, there is a weakness here. A tag good to merge
looks good. The question is: does he wait the merge to review the issue or does he wait the go of the merger?
When does the PO closes the issue: when the PR is merged or when the version is published?
When the version is published. The PO is the voice and the eyes of the user. If an user can't deploy the new code, the problem is not solved from his point of view.
from cozy-guidelines.
You'll say that I'm a little bit obtuse, but I'm convinced that a tool like HuBoard can resolve our workflow-by-tags processes. This way, the tags can be added/remove to issues, following the kanban, and preserves from human errors or misused. We can add more steps to reflects the life-cycle of an issue, like:
- assigned
- in-progress
- review
- to merge
- to release
The issue will be close when the new version is released.
from cozy-guidelines.
Huboard doesn't allow to change the column names.
from cozy-guidelines.
Thank you @frankrousseau I understand much better how you think the PO role. The fact that I won't be able to review code from the project I am PO on annoys me, but I understand the logic behind it.
I like @m4dz tag names, from a Trello-like interface point of view that could look:
- backlog
- sprint (non assigned + assigned, I don't see the state "assigned" managed by a tag, there is only a feature for that)
- in-progress
- technical review (= technical review to do) (what @frankrousseau calls QA)
- functional review (= functional review to do) (also @frankrousseau calls QA)
- to merge / retake
- to release
That might be overkill though, but that's well delimited.
from cozy-guidelines.
Huboard doesn't allow to change the column names.
Of course, it can 😄 : https://github.com/rauhryan/huboard/wiki#labels-explained
from cozy-guidelines.
to merge / retake
I'm not really sure about the sense of retake vs in-progress. It's just a step forward, and I don't understand why it need a specific status?
from cozy-guidelines.
It says that you have to fix a done job. But in Kanban mode, it doesn't work well.
from cozy-guidelines.
I think we should not mixed, tickets and pull requests status. The current version of tickets is good enough. The fact that someone opens a Pull Request means that is waiting for a technial review.
Issue status will be:
- Backlog (listed)
- Todo (what to do for the current sprint)
- In Progress (Someone is working on it)
- QA (PR is opened here. Both technical and functional reviews occurs here, if something is wrong, the status go back to In progress)
- Published (The PR is merged and a new version is created.)
Pull request status:
- In progress.
- QA (if something is wrong, the status go back to In progress)
- Merged
Additional info: A PR is sync with an issue if it's related to a single issue. But most of time a PR contains several issue fixings.
Hubboard works well on project that uses a single board. I think we can let the choice to the PO between Trello and Hubboard.
from cozy-guidelines.
👍
from cozy-guidelines.
The problem left is the sequence between technical and functional review. I think it's ok if PO and TR communicate well. But it disturbs you too much. We can add a QA - tech and QA - functional status. But I'm afraid that it will make things too heavy.
from cozy-guidelines.
I forgot to mention that when a PR is merged, the issue stays in QA until it's published.
from cozy-guidelines.
Not relevant anymore, so I close!
from cozy-guidelines.
Related Issues (20)
- Spinner HOT 4
- Fonts HOT 1
- Use contextualized localisation files HOT 1
- How to write polyglot keys? HOT 8
- Use "not" instead of "!" in Coffeescript
- Update l10n guidelines HOT 1
- Add contributing guidelines HOT 2
- Move this repository to Github pages HOT 5
- Add a link to guidelines into the main repository
- How we should write mocha tests HOT 8
- Add doc on ducks HOT 1
- Standardization of git commit messages HOT 2
- Emojis in commit message HOT 9
- Add an optional scope to git messages HOT 2
- add a paragraph about breaking change
- REST responses HOT 5
- Improvements
- Release cycle / process HOT 2
- fast return HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cozy-guidelines.