Coder Social home page Coder Social logo

Improve error handling about cozy-data-system HOT 4 CLOSED

cozy avatar cozy commented on July 2, 2024
Improve error handling

from cozy-data-system.

Comments (4)

jsilvestre avatar jsilvestre commented on July 2, 2024

I think this should be handled here https://github.com/cozy/cozy-data-system/blob/master/server/middlewares/errors.coffee

from cozy-data-system.

aenario avatar aenario commented on July 2, 2024

We can't.

At this point, the error's message is already [Object object]. We want an Error object ASAP (so we have a stack trace) and then just pass it around with no changes.

Our code should aways be return callback err
or return callback new Error('our own message')
it should never be callback new Error(err)

We started doing this because cradle would often send a string or an object {} as the err. A PR has just been merged in cradle flatiron/cradle#235, so it will now always pass Error object as reply. Once this is published in npm, we should update it and remove all new Error(err) from the DS.

from cozy-data-system.

jsilvestre avatar jsilvestre commented on July 2, 2024

Fair enough :)

from cozy-data-system.

frankrousseau avatar frankrousseau commented on July 2, 2024

:+1

from cozy-data-system.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.