Comments (4)
I think this should be handled here https://github.com/cozy/cozy-data-system/blob/master/server/middlewares/errors.coffee
from cozy-data-system.
We can't.
At this point, the error's message is already [Object object]. We want an Error object ASAP (so we have a stack trace) and then just pass it around with no changes.
Our code should aways be return callback err
or return callback new Error('our own message')
it should never be callback new Error(err)
We started doing this because cradle would often send a string or an object {} as the err. A PR has just been merged in cradle flatiron/cradle#235, so it will now always pass Error object as reply. Once this is published in npm, we should update it and remove all new Error(err) from the DS.
from cozy-data-system.
Fair enough :)
from cozy-data-system.
:+1
from cozy-data-system.
Related Issues (20)
- Creation of a sharing controller HOT 4
- Fine-grained permission control through id
- TypeError: Cannot read property 'targetDocType' of null HOT 1
- 30G of cozy.couch - any chance of reducing it ? HOT 5
- “Application not authorized” should be less verbose
- cozy update crash on data-system update HOT 7
- Don't crash when index is not available HOT 2
- Convert binaries error
- TypeError: error:0606506D:digital envelope routines:EVP_DecryptFinal_ex:wrong final block length HOT 1
- Improve "Error: Application is not authorized" error handling
- TypeError: Cannot read property 'docType' of undefined HOT 1
- Diacritics in file name makes data-system crash HOT 4
- Add file checksum automatically HOT 1
- Error trying to download a large folder HOT 3
- Extract EXIF data when adding pictures HOT 1
- Allow to disable the inner indexer
- Files doesn't (always) generate previews of pictures HOT 1
- Error creating thumbnails: TypeError: Cannot read property 'id' of undefined
- Allow replication to access /replication/_all_docs URLs HOT 1
- Server error: Forbidden operation | Buffer isn't a JSON valid
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cozy-data-system.