Update sensors before displaying popup, if possible... about hwsensors

[CozmoNate]

Need to force to update sensors before opening the popup. It's requiers some minor modifications. I'll implement it in the next rev.

[CozmoNate]

I implemented it in one of the last revisions. It may be very short delay before sensors has got updated after opening menu because of asynchronous update function calls.

[RehabMan]

Yes, I noticed some improvement, but it is still pretty long (up to a second). I think part of the problem may be in this code, in FakeSMCKey::getValue:

    if (handler) {
        if (ptimer_read() - lastUpdated >= NSEC_PER_SEC) {
            IOReturn result = handler->callPlatformFunction(kFakeSMCGetValueCallback, true, (void *)key, (void *)value, (void *)size, 0);

            if (kIOReturnSuccess == result)
                lastUpdated = ptimer_read();

Might be kind of tricky to force a read from the plugin handler in this case... Got any ideas?

[CozmoNate]

If you didn't updated sensors more when second FakeSMCKey::getValue: call will update it without delay.

I just submitted optimized version but sensors update itself take a time. Like fan sensing for some nVidia cards can take hundred milliseconds before value will be updated in opened menu.

P.S. It's possible to force to update each sensor asynchronously but I am afraid it may cause hardware glitches...

[RehabMan]

It is excellent now. Thanks!

[CozmoNate]

Not excellent in my case as I described above but.. Seems it's impossible to predict when the user wants to open menu, so we'll leave it as is it is now ;)

[RehabMan]

This one looks like it has regressed. I'm now seeing "old" values that don't update for a second or more after opening the popup.

Can anything be done to fix it? Is there a notification for the popup before it is displayed?

[CozmoNate]

It's very possible that issue is back because popup window class has been completelly replaced with the new one. It was popupWillOpen event somethere in popup panel class and popup controller. Mabe I have forget to reimplement this event.

I've just tested the latest commit on my desktop (H77N-WiFi), but the issue remains.