MONITOR is not ACPI compliant with recent iasl compilers about hwsensors

[CozmoNate]

Just added MON0000 and FAN0000, but as I see the name must be 7 chars long not 8.

[RehabMan]

Thanks, but I really need FAN00000 (5-zeros), otherwise I will forever have my own branch.

According to ACPI spec: "A valid PNP ID must be of the form "AAA####" where A is an uppercase letter and # is a hex digit. A valid ACPI ID must be of the form "NNNN####" where N is an uppercase letter or a digit ('0'-'9') and # is a hex digit. This specification reserves the string "ACPI" for use only with devices defined herein. It further reserves all strings representing 4 HEX digits for exclusive use with PCI-assigned Vendor IDs."

So, the seven character type is a PNP ID, and the 8 char one is ACPI ID.

[CozmoNate]

I tried to compile my DSDT with MON00000 (5 digits) and it fail to match to IOPrimaryMathcing. I decompiled DSDT and see the name is changed to MON0000 (4 digits). I has an older IASL compiler, but I don't think I'll change it in near future...

[CozmoNate]

Sorry, my fault. Need to use _HID instead of compatable ID (_CID)

[CozmoNate]

ASL Optimizing Compiler version 20110623-64 [Jun 23 2011]

ame (_HID, EisaId ("MON00000"))
Error 4037 - EISAID string must be of the form "UUUXXXX" (3 uppercase, 4 hex digits) ^ (MON00000)

Name (_CID, EisaId ("MON00000"))
Error 4037 - EISAID string must be of the form "UUUXXXX" (3 uppercase, 4 hex digits) ^ (MON00000)

[CozmoNate]

ASL Optimizing Compiler version 20121114-32 [Nov 25 2012]

/Users/kozlek/Desktop/Clover/EFI/OEM/P55-USB3/ACPI/patched/DSDT.dsl 436: Name (_HID, EisaId ("MON00000"))
Error 4045 - EISAID string must be of the form "UUUXXXX" (3 uppercase, 4 hex digits) ^ (MON00000)

[RehabMan]

Here is snippet from 4530s Probook DSDT:

Device (SMCD)
{
    Name (_HID, "FAN00000")  // _HID: Hardware ID
    Method (FAN0, 0, Serialized)
    {
        Store (\_TZ.GFRM (), Local0)
        If (LEqual (0x03C4, Local0))
        {
            Store (Zero, Local0)
            Return (Local0)
        }

        Return (Local0)
    }

    Method (TCPU, 0, Serialized)
    {
        Acquire (\_SB.PCI0.LPCB.EC0.ECMX, 0xFFFF)
        Store (One, \_SB.PCI0.LPCB.EC0.CRZN)
        Store (\_SB.PCI0.LPCB.EC0.DTMP, Local0)
        Release (\_SB.PCI0.LPCB.EC0.ECMX)
        Return (Local0)
    }
 ...

}

Not using EisaID...

[CozmoNate]

Compiler requires EisaID compatible name. I don't understand how you where able to compile this code but anyway I've added this long names into matching dictionary.

[RehabMan]

Thanks for this addition!

And for future reference, here is some code examples from the ACPI 5.0 spec, Dec 6 2011 (page 257, _HID section):

Example ASL:
Name (_HID, EISAID ("PNP0C0C")) // Control-Method Power Button
Name (_HID, EISAID ("INT0800")) // Firmware Hub
Name (_HID, "ACPI0003") // AC adapter device
Name (_HID, "MSFT0003") // Vendor-defined device
Name (_HID, "80860003") // PCI-assigned device identifier

Yes... the code we have is valid, and thus the compiler accepts it.