Coder Social home page Coder Social logo

Comments (19)

robby-d avatar robby-d commented on July 30, 2024

Best thing to do im thinking is to put a notice about this on the 3rd page of buysell (order confirmation) when selling btc.

from counterwallet.

ouziel-slama avatar ouziel-slama commented on July 30, 2024

maybe also a confirmation modal box if you try logout or close tab.

2014-04-09 19:36 GMT+00:00 xnova [email protected]:

Best thing to do im thinking is to put a notice about this on the 3rd page
of buysell (order confirmation) when selling btc.

Reply to this email directly or view it on GitHubhttps://github.com//issues/57#issuecomment-40007001
.

from counterwallet.

adamkrellenstein avatar adamkrellenstein commented on July 30, 2024

I like that idea! (It's obnoxious, of course.)

from counterwallet.

ouziel-slama avatar ouziel-slama commented on July 30, 2024

:-) Yes obnoxious but effective.

2014-04-09 20:24 GMT+00:00 PhantomPhreak [email protected]:

I like that idea! (It's obnoxious, of course.)

Reply to this email directly or view it on GitHubhttps://github.com//issues/57#issuecomment-40012043
.

from counterwallet.

adamkrellenstein avatar adamkrellenstein commented on July 30, 2024

Bump.

from counterwallet.

adamkrellenstein avatar adamkrellenstein commented on July 30, 2024

The warning should say something like 'Because the Counterparty servers have no access to your funds, pending order matches in which you are selling BTC can only be completed while you remain logged in.'

It would be even better if the warning only showed up for users that actually have such open orders to sell BTC and pending order matches involving selling BTC. The pop-up could list the orders and order matches in question.

from counterwallet.

robby-d avatar robby-d commented on July 30, 2024

An alternative (or something to do in addition to this) is to, as long as the user has 1 or more open orders selling BTC, place a notice on their balances page (i.e. the blue info notice bar at http://wrapbootstrap.com/preview/WB0573SK0) saying "As you have one or more open sell orders for BTC< please stay logged in so that the order(s) can be properly filled."

You can also change the logout confirmation text as well when the user logs out to what Phantom stated. Doing this info bar catches folks that just close the browser (and do not formally log out), which I think is probably at least half of folks.

We already show a confirmation dialog at logout, you would just add to that to show Phantom's notice then, and have this info bar in addition.

from counterwallet.

ouziel-slama avatar ouziel-slama commented on July 30, 2024

Just did a push online with this commit:
251d210

if sellingBTC()==true :

I still have to add the blue info notice. I do not see in the link, can you
send me a screenshot please?

2014-04-11 14:03 GMT+00:00 xnova [email protected]:

An alternative (or something to do in addition to this) is to (as long as
the user has 1 or more open orders selling BTC, place a notice on their
balances page (i.e. the blue info notice bar at
http://wrapbootstrap.com/preview/WB0573SK0) saying "As you have one or
more open sell orders for BTC< please stay logged in so that the order(s)
can be properly filled."

You can also change the logout confirmation text as well when the user
logs out to what Phantom stated. Doing this info bar catches folks that
just close the browser (and do not formally log out), which I think is
probably at least half of folks

Reply to this email directly or view it on GitHubhttps://github.com//issues/57#issuecomment-40206594
.

from counterwallet.

ouziel-slama avatar ouziel-slama commented on July 30, 2024

i think we need also check if there is pending or open btc sell orders. Not
only btcpays. And keep verification, for instance with the two counters i
created for that:
window.OPEN_ORDER_FEED.sellBTCOrdersCount()
window.PENDING_ACTION_FEED.pendingSellBTCOrdersCount()

2014-04-13 22:25 GMT+00:00 xnova [email protected]:

Closed #57 #57 via 5c357415c35741
.

Reply to this email directly or view it on GitHubhttps://github.com//issues/57
.

from counterwallet.

adamkrellenstein avatar adamkrellenstein commented on July 30, 2024

What's the status on this? We also need the info notice.

This is very important. People are going to log out, the DEx is going to not work, and they're going to walk away!

from counterwallet.

adamkrellenstein avatar adamkrellenstein commented on July 30, 2024

'You need to be logged in as long as you're trying to sell BTC.'

from counterwallet.

adamkrellenstein avatar adamkrellenstein commented on July 30, 2024

It needs to be on both the Buy & Sell page, and everywhere else... and big.

from counterwallet.

adamkrellenstein avatar adamkrellenstein commented on July 30, 2024

The vast majority of open orders selling BTC have zero fees left, because the order matches have all expired. And the fee_provided filter (and the fee_required filter?) on the Buy & Sell page is not for fee_provided remaining, as it must be. (This is important, too, because the order book looks very wrong otherwise.)

from counterwallet.

robby-d avatar robby-d commented on July 30, 2024

Did you see that when you try to close the window, you get a pop up?

I think that given that, putting it everywhere is excessive, and contributes to UI overload where people just start ignoring those notices alltogether.

We have it on the balances page...adding the notice to the buysell page may make sense, and making it stick out more would as well (I have to see how it looks now...we could put it in a warning box)

Regarding your other issue, can you open that as a separate item? Ouziel can get to both today most likely.

from counterwallet.

adamkrellenstein avatar adamkrellenstein commented on July 30, 2024

I opened the other issue, yeah.

The pop-up is really only for Chrome, and then only if you close the page in certain ways. Of course UI-overload is an issue, but this is very important. We need to prove that the DEx works.

The notice on the balances page isn't what I'm talking about. That only says 'It takes times for transactions to be confirmed.' We need a warning-type message that says 'Don't log out or your orders to sell BTC won't go through!'

from counterwallet.

adamkrellenstein avatar adamkrellenstein commented on July 30, 2024

We can also put a red notice in the 'Open Orders' and 'Pending Actions' drop-down menus, when it's relevant.

from counterwallet.

adamkrellenstein avatar adamkrellenstein commented on July 30, 2024

Another point is that people are losing a lot of money in BTC fees because of this problem. Order matches cost the seller of BTC real money if they don't send the BTCpays when they need to.

from counterwallet.

adamkrellenstein avatar adamkrellenstein commented on July 30, 2024

Remember: this is both for orders to sell BTC (unconfirmed and confirmed) and for order matches of such sell orders pending BTCpay.

from counterwallet.

ouziel-slama avatar ouziel-slama commented on July 30, 2024

yes, we check pending/confirmed orders and btcpays.

from counterwallet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.