Comments (3)
tessr
commented on May 24, 2024
I am in favor of this, I think. I just found myself wishing these fields were exported while trying to write a toy program--not sure if that's actually representative of what people want to do with this package, though.
from iavl.
erikgrinaker
commented on May 24, 2024
Yeah, I’d say it’s generally bad form to expose private types as publicly accessible values - i.e. Leaves []proofLeafNode elements are publicly accessible, but of a private type.
from iavl.
tessr
commented on May 24, 2024
Another great point.
from iavl.
Related Issues (20)
- iaviewer doesn't work HOT 2
- Inner node proofs should require either the left or right node be empty HOT 3
- Proof: Remove RangeProofs in favour of only ics23 HOT 2
- Improve docs to clarify definition of an inner node's key
- Modify the key format of node in DB to a sequential integer ID instead of the hash value. HOT 4
- The immutableTree clone() func is missing skipFastStorageUpgrade field --> wrong Block.Header.AppHash. error in the blockchain HOT 3
- move internal api to internal
- fastnode causing excessive disk thrashing HOT 5
- Problem: possible app-mismatch from `enableFastStorageAndCommitIfNotEnabled` HOT 1
- fastnode: DeserializeNode doesn't check that decoded varint is in bounds length of buffer HOT 1
- iaviewer cannot show versions
- `skipFastStorageUpgrade` a little confusing to followup HOT 2
- IsFastCacheEnabled is activated performantly after skipFastStorageUpgrade is false HOT 1
- iavl: *MutableTree doesn't provide a way to release the database; noticed inside iavl/cmd/iaviewer.ReadTree
- Refactor One Large Commit Into Smaller Batches HOT 7
- Optimise iavl storage for archive mode HOT 6
- Osmosis did it perfectly, the bool kills it
- prune versions without bookkeepings HOT 1
- iavl start up time is slow
- LoadVersionForOverwriting doesn't commit HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iavl.