Coder Social home page Coder Social logo

Disable proto2 about cosmos-proto HOT 7 OPEN

cosmos avatar cosmos commented on June 9, 2024
Disable proto2

from cosmos-proto.

Comments (7)

fdymylja avatar fdymylja commented on June 9, 2024 1

Maybe an error is better for now since it's unintended usage?

for me its fine to throw an error and say we don't generate files defined with proto2 syntax

from cosmos-proto.

aaronc avatar aaronc commented on June 9, 2024

How would the fallback look like?

from cosmos-proto.

fdymylja avatar fdymylja commented on June 9, 2024

How would the fallback look like?

Most likely I'd fall back to this function from protoc-gen-go -> https://github.com/protocolbuffers/protobuf-go/blob/v1.27.1/cmd/protoc-gen-go/internal_gengo/main.go#L68

from cosmos-proto.

aaronc avatar aaronc commented on June 9, 2024

Basically anytime a message declares extensions ... to ... it would fallback? I also think it's fine to just fail.

from cosmos-proto.

fdymylja avatar fdymylja commented on June 9, 2024

Basically anytime a message declares extensions ... to ... it would fallback? I also think it's fine to just fail.

the fall back would be like -> if fileDescriptor.Syntax == "proto2" -> google-gen-go.GenerateFile.

Protobuf does not allow extensions unless you declare at top level this:

syntax="proto2";
...

Also for me failing is fine.

from cosmos-proto.

aaronc avatar aaronc commented on June 9, 2024

Maybe an error is better for now since it's unintended usage?

from cosmos-proto.

aaronc avatar aaronc commented on June 9, 2024

The only exception would be if we had to codegen for third-party files, but then you should just generate those separately

from cosmos-proto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.