Comments (7)
Maybe an error is better for now since it's unintended usage?
for me its fine to throw an error and say we don't generate files defined with proto2 syntax
from cosmos-proto.
How would the fallback look like?
from cosmos-proto.
How would the fallback look like?
Most likely I'd fall back to this function from protoc-gen-go -> https://github.com/protocolbuffers/protobuf-go/blob/v1.27.1/cmd/protoc-gen-go/internal_gengo/main.go#L68
from cosmos-proto.
Basically anytime a message declares extensions ... to ...
it would fallback? I also think it's fine to just fail.
from cosmos-proto.
Basically anytime a message declares
extensions ... to ...
it would fallback? I also think it's fine to just fail.
the fall back would be like -> if fileDescriptor.Syntax == "proto2" -> google-gen-go.GenerateFile
.
Protobuf does not allow extensions unless you declare at top level this:
syntax="proto2";
...
Also for me failing is fine.
from cosmos-proto.
Maybe an error is better for now since it's unintended usage?
from cosmos-proto.
The only exception would be if we had to codegen for third-party files, but then you should just generate those separately
from cosmos-proto.
Related Issues (20)
- Utility for dynamicpb.NewMessageType + known types HOT 1
- Documentation?
- Reconcile protoreflect.Message.ProtoMethods codegen HOT 3
- AST Patcher Shifts Comments HOT 1
- bring in protoc-gen-go
- fast feature: Range impl only runs on non-default values
- proto.Methods.Marshal/Unmarshal: function and variable redeclaration HOT 6
- FastReflection: handle nested messages
- goproto fork produces malformed generated code with enums and maps HOT 2
- add tests for extensions
- Canonical marshalling for imported messages HOT 1
- Move everything that shouldn't be exported to internal packages HOT 2
- Setup buf and push to buf schema registry
- Create a buf remote generation plugin HOT 1
- add license/vtproto acknowledgement
- tests: move every test to use fuzzing on TestAllTypes
- fix field/method conflict HOT 4
- Need DO NOT EDIT comment
- json: add feature to disallow omitempty HOT 1
- v1.0 Readiness Checklist
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cosmos-proto.