SDL2: Map Editor does not compile about corsixth

[TheCycoONE]

I've been reading into how SDL2 might be mixed with a gui library like wxWidgets, for instance they discuss the topic in the SDL forums here ( https://forums.libsdl.org/viewtopic.php?p=39332&sid=f05ee8efa396f3bc4b74f97e8c58a4c5 ).

Unfortunately I haven't found any solutions, besides porting the GUI portion of the map editor to SDL2, or making an OpenGL map viewer just for the editor.

@jorgenpt I remember you were talking about a possible option with this, could you elaborate here?

[mrtnptrs]

How are we going to handle this? @jorgenpt

[jorgenpt]

@TheCycoONE I think what I was referring to was SDL_CreateWindowFrom, but it seems like that method is not yet usable, as it does not work with OpenGL contexts. Rewriting the GUI portion using SDL2, or ensuring that SDL supports a way of creating a window with OpenGL capabilities from an existing window and then that the SDL_Render functionality works with it as intended (with a restricted viewport) are likely our best two options.

I can investigate the latter one the next time I have some free time - I'm a committer to SDL, so I can try to get the necessary changes in the next release, since others need it too.

This looks to me to be one of the large remaining pieces for full SDL2 support, correct?

[MarkL1961]

I am sure that I have mentioned this before somewhere, if there are issues with the map editor and sdl2, why not leave it as it is? The map editor does not get many updates to it and it is a stand alone exec anyway. So does it matter that you need opengl to compile it, it has other dependencies that the main game does not need?

[TheCycoONE]

@jorgenpt yes, I think this is the only thing holding back sdl2 at the moment. The music regression is annoying but not the end of the world.

@MarkL1961 The map editor shares a large amount of code with the game, and that code is dependent on sdl1. We could release a package containing the old map editor compiled out of the 0.30 branch with the rest of the components from the sdl2/0.40 branch but it isn't a long term solution.

We have a number of options. Probably the nicest, but the most work, is to port the map editor away from using wxWidgets. On the other side of the spectrum, we could clone CorsixTH based off the 0.30 branch, and strip out everything not related to the map editor so it becomes it's own SDL1/OpenGL project with it's own release cycle and own installer. (Presumably the level editor would live there too)

[rallymoose]

just a tip... take a look at: https://github.com/bkaradzic/bgfx#what-is-it
or maybe https://github.com/Olivier-Boudeville/OSDL-Heavy
might help?

[TheCycoONE]

The approach I've been advocating for is to make the map editor part of CorsixTH with SDL2. This allows reusing the most code. I have been suggesting that people could take over from my own early experiments with this at https://github.com/TheCycoONE/CorsixTH/tree/sdl2_mapedit_builtin if they want, or start from scratch and copy the functionality out of MapEdit into CorsixTH dialogs.

That said, if someone submits a cross platform map editor that works (using any technology, toolkit, or rendering engine) it will be appreciated.

[Lego3]

We are working on integrating the Map Editor into the game, that is being tracked in #639 .