Performance issues with app-sidebar-nav components due to ngClass bindings about coreui-angular

[coyoteecd]

@xidedix
Sorry for the delayed response, I had to wait for a good time to upgrade our app to Angular 8 to be able to use 2.5.3.

The pipe fix works fine. There is still one left-over however, you'd need to include it here as well:

coreui-angular/projects/coreui/angular/src/lib/sidebar/app-sidebar-nav/app-sidebar-nav-dropdown.component.ts

Lines 11 to 13 in bd5fd37

	<i *ngIf="helper.hasIcon(item)" [ngClass]="helper.getIconClass(item)"></i>
	<ng-container>{{item.name}}</ng-container>
	<span *ngIf="helper.hasBadge(item)" [ngClass]="helper.getBadgeClass(item)">{{ item.badge.text }}</span>

. That component still uses the old helper and consequently triggers the same removeClass/addClass cycle on every key press.

[coyoteecd]

Related issues in the Angular repo:
angular/angular#25518
angular/angular#28201
angular/angular#27804

[xidedix]

Hi @coyoteecd
Thanks for the heads-up and comprehensive analysis of the issue.
We are going to investigate this further.

PR welcome!

[xidedix]

We're currently testing the use of custom pipes instead of helper functions in templates for badge/icon classes. Seems promising.

[xidedix]

@coyoteecd
Please update to 2.5.3 and let us know if it helps in your case.

[xidedix]

@coyoteecd done - please update to 2.5.5