Coder Social home page Coder Social logo

Comments (5)

Cordobo avatar Cordobo commented on July 22, 2024 3

Rather than introduce breaking changes into the component, I would check (in your code) if this.QrCode equals an empty string as condition whether to render the component or a placeholder. You can use NgIf to conditionally add or remove the component from the DOM https://angular.io/api/common/NgIf

HTH

from angularx-qrcode.

Cordobo avatar Cordobo commented on July 22, 2024

Thanks @alberk8 for your report, I look into it

from angularx-qrcode.

alberk8 avatar alberk8 commented on July 22, 2024

Thanks. I understand your concern on breaking the code. If possible, please do implement a way where you can allow empty string for the QRCode on the next release. The reason is that the current code stops/halt when there is a empty string which is a bit of a problem for a newbie.

image

My suggestion, is for the default behavior to display an empty QR code with an option to display nothing. Thank you.

from angularx-qrcode.

Cordobo avatar Cordobo commented on July 22, 2024

That's a good argument and it won't break. Feel free to send in an Merge Request or I try to introduce it into the next release.

from angularx-qrcode.

Cordobo avatar Cordobo commented on July 22, 2024

Fixed in 1.0.2

from angularx-qrcode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.