Comments (6)
Maybe this is the right time to introduce an async queue in the bot? You could trigger the check event at every push to master, but indeed place it in a work queue with delay. This way the timer is not associated to the event.
Even better would be for the both to have access to the trees [and maybe run git by itself], but that looks more complicated.
from bot.
One further advantage of having a queue is that newer jobs can cancel / override older ones.
[by the way, such kind of queue is what's needed for asyncronous proof processing :D]
from bot.
The bot runs git
already to be able to push to GitLab so we could indeed check locally for the conflicts, but this would require pulling all PRs, so it seems more sensible to use the info already computed by GitHub...
from bot.
An async queue would be something like what is provided by https://github.com/c-cube/lwt-pipe?
from bot.
An async queue would be something like what is provided by https://github.com/c-cube/lwt-pipe?
Indeed, I think so !
from bot.
In the end, this was implemented by using an external Action.
from bot.
Related Issues (20)
- Minimizer should handle more kinds of shell blocks
- Minimizer is treating all code blocks as Coq HOT 4
- Document coqbot autominimizer defaults HOT 2
- Auto resumption for non-ci-minimization HOT 1
- Print warnings from GraphQL API results in log.
- coqbot minimizer should upload and attach the file to GH when it's truncated HOT 1
- Migrating the backporting tracking mechanism to Projects V2. HOT 6
- Document coqbot bench.
- Reduce log verbosity by printing less output for git commands HOT 2
- Incorrect link to gitlab pipeline in github check HOT 2
- `update_bench_status` should check whether status is valid before querying GitHub.
- Issue in the bug minimizer code with the call to git push --delete.
- Support for `@coqbot run full CI` in PR body. HOT 1
- coqbot can show light pipeline as cancelled when full pipeline is running.
- Using coqbot to run OCaml benchmarks HOT 3
- Add backoff strategy to auto retry of failing CI jobs HOT 7
- ci minimization is broken due to change in format of reporting results HOT 4
- [CI minimization] File name should include project info rather than be `bug.v`
- Bot doesn't generate CI merge commits anymore HOT 1
- "needs" and "request full CI" should be removed only after the pipeline is successfully started
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bot.