Coder Social home page Coder Social logo

Feature: check PRs for merge conflicts about bot HOT 6 CLOSED

coq avatar coq commented on July 22, 2024 1
Feature: check PRs for merge conflicts

from bot.

Comments (6)

ejgallego avatar ejgallego commented on July 22, 2024 1

Maybe this is the right time to introduce an async queue in the bot? You could trigger the check event at every push to master, but indeed place it in a work queue with delay. This way the timer is not associated to the event.

Even better would be for the both to have access to the trees [and maybe run git by itself], but that looks more complicated.

from bot.

ejgallego avatar ejgallego commented on July 22, 2024 1

One further advantage of having a queue is that newer jobs can cancel / override older ones.

[by the way, such kind of queue is what's needed for asyncronous proof processing :D]

from bot.

Zimmi48 avatar Zimmi48 commented on July 22, 2024

The bot runs git already to be able to push to GitLab so we could indeed check locally for the conflicts, but this would require pulling all PRs, so it seems more sensible to use the info already computed by GitHub...

from bot.

Zimmi48 avatar Zimmi48 commented on July 22, 2024

An async queue would be something like what is provided by https://github.com/c-cube/lwt-pipe?

from bot.

ejgallego avatar ejgallego commented on July 22, 2024

An async queue would be something like what is provided by https://github.com/c-cube/lwt-pipe?

Indeed, I think so !

from bot.

Zimmi48 avatar Zimmi48 commented on July 22, 2024

In the end, this was implemented by using an external Action.

from bot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.