Comments (6)
if you change that to Launchy.open("http://google.com/?q=launchy's+great", :dry_run => true)
then it should output the exact parameters that were sent to system()
. My initial thought is that the system call itself is wrapping the parameter in quotes, as it I don't think Launchy is.
If you can do that along with the debug, that should add some additional help. I don't have a windows machine to do this testing on, so all my windows fixing is done by generous folks like yourself.
Does start have the same syntax in all versions of windows? Could the possibility exist that there are slight differences between windows versions that i'll need to check?
from launchy.
The other item to possibly check is the use of #shellsplit
in https://github.com/copiousfreetime/launchy/blob/master/lib/launchy/detect/runner.rb#L85. If you change that to just #split
does everything work just fine?
from launchy.
My initial thought is that the system call itself is wrapping the parameter in quotes, as it I don't think Launchy is.
You're right. Looking at the documentation for system, the call behaves differently depending on the arguments specified.
The array version used in Launchy in runner.rb
allows the system
call to manipulate the command-line arguments. Using Process Monitor, I verified that the URL argument was indeed quoted.
Ultimately, I think we just have to appease start
's unfortunate command-line syntax. I think the right fix here is to always specify the command in the form of cmd /c start /b "" "http://google.com/?q=launchy's+great"
since the URL argument might have spaces and might need to be quoted anyway.
I'll submit a fix when I get the chance and ensure that this is the right behavior for all supported versions of Windows.
from launchy.
Excellent, and don't forget to add yourself to CONTRIBUTING.md
from launchy.
Hi @schmich checking in to see if you ever created a patch for this issue.
from launchy.
version 2.4.0 released which I hope fixes this. If you can, please verify.
from launchy.
Related Issues (20)
- Settings get cleared after some time HOT 1
- "Unable to find a browser command" when using launchy in gitpod and other IDE's HOT 3
- Rspec E2E testing function HOT 2
- Please rerun with environment variable
- 1
- Anyway to set the browser tab like in <a href="" target="">? HOT 6
- Launchy seems to error since 28th Feb since 2.5.0 was released HOT 3
- (WSL) Failing calls to xdg-open in do not trigger exception block HOT 2
- Launchy::CommandNotFoundError HOT 1
- Launchy 2.5 introduces breaking changes by requiring ruby 2.4 HOT 1
- Failure: Launchy::Application::Browser#test_0002_when host_os is 'darwin' the appropriate 'app_list' method is called HOT 1
- Launchy::CommandNotFoundError HOT 1
- useMatcapTexture broken? HOT 1
- Support for WSL: Spaces in cmd path, translate pathname from WSL2 to Windows HOT 6
- High severity vulnerability in gem dependency HOT 1
- / HOT 1
- Incompatible with the `debug` gem? (`after_fork': undefined method `open' for #<DEBUGGER__::ProcessGroup) HOT 2
- Deprecated: remove deprecated.rb
- Typo: in https://github.com/copiousfreetime/launchy/blob/master/lib/launchy/detect/ruby_engine.rb#L18
- Arc Integration HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from launchy.