Coder Social home page Coder Social logo

Comments (11)

OneHoopyFrood avatar OneHoopyFrood commented on June 1, 2024 1

What is the alternative? However, it might be good to make it an array, so it can take multiple root directories. I could use this use case in one of my own projects.

from hapi-auto-route.

OneHoopyFrood avatar OneHoopyFrood commented on June 1, 2024

Shall I take the thumbsup as a "go ahead?" If so, I'll mark this as an enhancement.

from hapi-auto-route.

onoyr avatar onoyr commented on June 1, 2024

You can go ahead. Apart from that, I think that it's important to make route prefix configurable for each directory.

from hapi-auto-route.

OneHoopyFrood avatar OneHoopyFrood commented on June 1, 2024

We still need to implement configurable prefix per directory. I think that's best handled with a new enhancement issue. After the PR is accepted and merged, let's close this and open a new one for that with a reference.

from hapi-auto-route.

OneHoopyFrood avatar OneHoopyFrood commented on June 1, 2024

I can't update the npm package. Would you mind doing the release @sitraka-hq ?

from hapi-auto-route.

OneHoopyFrood avatar OneHoopyFrood commented on June 1, 2024

Also, did you happen to do some testing? I would like an independent party to verify it works properly.

from hapi-auto-route.

OneHoopyFrood avatar OneHoopyFrood commented on June 1, 2024

Found some disfunction. Testing and correcting. Undid the PR for now. Will update and re-submit.

from hapi-auto-route.

OneHoopyFrood avatar OneHoopyFrood commented on June 1, 2024

Ignore that ^
Discovered the revert PR function too late. I did a reset on the master branch and force pushed. Won't do that again in the future, sorry.

from hapi-auto-route.

onoyr avatar onoyr commented on June 1, 2024

I can't update the npm package. Would you mind doing the release @sitraka-hq ?

This functionality will be release with the #22.

from hapi-auto-route.

onoyr avatar onoyr commented on June 1, 2024

I tested your code and it was ok! I restored your change in #23. I also profited to update some dependencies.

I think that everything is ok now!

from hapi-auto-route.

OneHoopyFrood avatar OneHoopyFrood commented on June 1, 2024

Oh, it does def have some issues. I tried it out in a project and it fell apart. I've since worked it out though. I'll be making a new push today.

from hapi-auto-route.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.