Coder Social home page Coder Social logo

Comments (2)

godu avatar godu commented on July 23, 2024

@asprouse Could you give me a way to reproduce ?

from serverless-plugins.

asprouse avatar asprouse commented on July 23, 2024

This happens in serverless-offline-dynamodb-streams on line 165 you can observe end being emitted by simply inserting an on call to the readable:

const readable = DynamoDBReadable(
        dynamodbStreamsClient,
        streamARN,
        assign(this.config, {
          shardId,
          limit: tableEvent.batchSize,
          iterator: tableEvent.startingPosition || 'TRIM_HORIZON'
        })
      );

      readable.on('end', () => console.log('Readable End!');

      readable.pipe(
        new Writable({
          objectMode: true,
          write: (chunk, encoding, cb) => {
            this.eventHandler(streamARN, functionName, shardId, chunk, cb);
          }
        })
      );
    }, shards);

Since you are implementing your own writable this isn't an issue here but write streams are supposed to close when end is emitted.

from serverless-plugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.