Comments (3)
Hey, Initially I was going to do this, and even now it would be just a line change. But the reason I did not do it is because it is already available on window
. In other words, anywhere where you would want to access web3 in context, you would also be able to access it on window
, so there really is no benefit to having it in context.
from react-web3.
Closing this, feel free to re-open if the above does not address your concern
from react-web3.
I'm using this in a TypeScript setting, and in that context, it is un-ideal to use window.web3
. The reason for that is that window.web3
could be undefined (e.g. in a browser without Metamask). If the context passed it down, then I would be sure that it is not going to be undefined.
from react-web3.
Related Issues (20)
- Typo HOT 1
- react-web3 not picking up user switching accounts HOT 4
- [email protected] - 'cb is not a function' HOT 6
- Make compatible with web3 1.0 HOT 5
- enable to use ethjs? HOT 1
- Q: Does the child context mean I no longer have to import web3? HOT 4
- Upgrade to React 16.2? HOT 4
- Chrome problems with Metamask HOT 1
- web3 1.0: MetaMask throws `TypeError: e is not a function` if web3 is imported HOT 3
- doesn't work with mist HOT 1
- How to detect if a user logout of metamisk? HOT 1
- how can i start project.. HOT 1
- Is there any way to customize the error message? HOT 3
- Breaking changes for using MetaMask HOT 9
- No eth account available being displayed for a couple of milliseconds when page is being loaded. HOT 4
- Relies on legacy React context API HOT 1
- How can i use react-redux and Web3Provider both work together? HOT 1
- Throws error if no web3 at window
- How to read account balance?
- Warning: Failed child context type: Invalid child context `web3.networkId` of type `string` supplied to `Web3Provider`, expected `number`. in Web3Provider (at src/index.js:13)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-web3.