Coder Social home page Coder Social logo

Comments (3)

abyrd avatar abyrd commented on July 30, 2024

This seems to be the reason: https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
Someone could submit a PR that causes Travis to print out all your secure variables. Currently encrypted variables are made available by Travis only in "safe" PRs, "as long as the origin of the pull request and the target repository are the same".

So rather than testing whether this is a PR, we should test whether the AWS credentials are defined.

from analysis-backend.

abyrd avatar abyrd commented on July 30, 2024

This leads to another problem: the $TRAVIS_BRANCH on pull requests is the branch the PR is merged into, not the branch of the PR itself. So the JAR file is often called master-X.jar instead of having the right branch name.

from analysis-backend.

ansoncfit avatar ansoncfit commented on July 30, 2024

We plan to switch CI providers. Closing.

from analysis-backend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.