Comments (5)
Not sure how to fix this... #4
There are three links in that issue and I was trying to make the regex work for those use cases. Do you have any reference of how JIRA references issues? does it have to have a #
before the number? in your example it looks like you have to have a -
before the number? So makebe we should make the #
configurable?
from conventional-commits-parser.
I think this is a good idea, we should make the (?:gh-|#)
configurable.
from conventional-commits-parser.
Jira issues are in the form of [PROJECTNAME]-[ISSUENUMBER], which translates in the url as [url to jira]/browse/[PROJECTNAME]-[ISSUENUMBER],
So an issue in the project FOO would look like FOO-123 and have the url http://jira.com/browse/FOO-123
Ik think the most versatile wat is indeed to make the prefix configurable. (And maybe have the gh- and # prefixes by default)
from conventional-commits-parser.
I have pushed the rewrite to the master branch of conventional-changelog
The url should be configurable at https://github.com/stevemao/conventional-commits-writer. Its using handlebars template with customised context variables (open an issue there if you can't do it).
In the rewrite we have https://github.com/ajoslin/conventional-changelog/tree/master/hosts where you put your default settings for different hosts.
I think we can make an option issuePrefix
here defaults to '#'
, and make 'gh-'
and '#'
as defaults at https://github.com/ajoslin/conventional-changelog/blob/master/hosts/github.json
from conventional-commits-parser.
conventional-changelog/conventional-changelog#60
from conventional-commits-parser.
Related Issues (20)
- Change header pattern so that it can match any number of parts
- expose owner :D
- expose lib/parser as a sync function
- trim all parts
- Should preserve newlines in a part HOT 1
- change issuePrefixes to referencePrefixes HOT 1
- expose msg.reference.referencePrefix
- noteKeywords should be case insensitive
- Using a regex for issuePrefixes HOT 21
- any noteKeywords must be at the beginning of a sentence.
- mentions `@` support
- referencing a commit in parenthesis results in a parsing error HOT 3
- Merge Request ID for GitLab HOT 5
- Apparently "important changes" may have more than one paragraph HOT 1
- Support other formats of references HOT 1
- CLI
- make `headerPattern` more flexible
- regex tests are not useful
- Tool to prompt user for commit HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from conventional-commits-parser.