Comments (8)
Fix is being worked on in #91
from graphql-helix.
Confirmed as resolved in 0.9.1.
from graphql-helix.
🎉
from graphql-helix.
this is related to execute removing support for positional args.
Args for execute were converted to be an object, but they key for context should have been updated to be contextValue
but is being passed as context
c8750f3#diff-6c8aa63d319597d6d7fff26fda262c760963d5a73d99ad303c0da528bbd376a5R140
Technically this was also a breaking change since any provided context function is now called with completely different arguments.
I think it would probably also make sense to align formatResult with this new API so both are called with contextValue
to keep things consistent (this is also a breaking change)
from graphql-helix.
Happy to submit an PR if you want, just need to know how to resolve this (which combination of the following fixes makes sense).
- Just call execute with the
contextValue
- Update types for custom execute function to accept same arg shape as default execute
- Map old execute format to new execute format so API does not change
- Update formatPayload to also accept context as
contextValue
from graphql-helix.
@ardatan can you please check this?
from graphql-helix.
Confirmed this. It also breaks usage with getEveloped (https://github.com/dotansimha/envelop)
from graphql-helix.
Working perfect now thanks!
from graphql-helix.
Related Issues (20)
- Avoid bundling GraphiQL HOT 3
- processRequest does not support multiple accept types HOT 2
- FastifyError: Promise may not be fulfilled with 'undefined' when statusCode is not 204 HOT 1
- Prohibiting SSE via POST breaks `graphql-sse` usage (since 1.11.0) HOT 6
- Fastify example - cannot set cookies HOT 5
- missing exports `send ... ResponseResult` from `node-http` in the barrel file
- Error: Cannot find module `<path>\node_module\graphql-helix\dist\dist.js` HOT 3
- Helix in Gateway to pass headers down to subschema? HOT 1
- graphql-ws example: Invalid query returns "Subscriptions should be sent over WebSocket" HOT 2
- Slow processRequest when error thrown HOT 1
- graphql-koa-example: subscriptions not working
- [Question] Have you thought about graphql-jit? HOT 2
- Adding `extensions` to `GraphQLParams`
- Is development dead? Zero commits since The Guild announced Yoga 2. HOT 1
- Infinite loop when using defer and async iterators (`JavaScript heap out of memory`)
- Can we detect/support cancelation of @stream operations?
- typescript compilation errors
- Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client HOT 1
- Before and after crud operation listeners
- Enabling CSP protection with koa + @koa/helmet causes 404 error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql-helix.