Comments (4)
@maraisr The graphql-js test case you are referring to is not using an AsyncGenerator resolver that yields values, but a resolver that resolves to an Array. I assume because of that graphql-js publishes the hasNext: false
as part of the last result that includes an item. Instead of a separate execution result
I created the following code-sandbox: https://codesandbox.io/s/pedantic-glitter-8tudl?file=/src/index.ts
It showcases that for an AsyncGenerator
the following results are published from execute
:
const schema = new graphql.GraphQLSchema({
query: new graphql.GraphQLObjectType({
name: "Query",
fields: {
stream: {
type: new graphql.GraphQLList(graphql.GraphQLString),
resolve: async function* () {
for (const word of ["ay", "sup", "oi"]) {
yield word;
}
}
}
}
})
});
[
{
"data": {
"stream": [
"ay"
]
},
"hasNext": true
},
{
"data": "sup",
"path": [
"stream",
1
],
"hasNext": true
},
{
"data": "oi",
"path": [
"stream",
2
],
"hasNext": true
},
{
"hasNext": false
}
]
Here is an example where the resolver only returns an Array of elements (similar to what the graphql-js test you are referring to is doing https://codesandbox.io/s/cool-hamilton-orizq?file=/src/index.ts
const schema = new graphql.GraphQLSchema({
query: new graphql.GraphQLObjectType({
name: "Query",
fields: {
stream: {
type: new graphql.GraphQLList(graphql.GraphQLString),
resolve: () => ["ay", "sup", "oi"]
}
}
})
});
[
{
"data": {
"stream": [
"ay"
]
},
"hasNext": true
},
{
"data": "sup",
"path": [
"stream",
1
],
"hasNext": true
},
{
"data": "oi",
"path": [
"stream",
2
],
"hasNext": false
}
]
The helix test you are referring to is working as expected. As the chunks[2] string is the following:
Content-Type: application/json; charset=utf-8
Content-Length: 47
{"data":"C","path":["stream",2],"hasNext":true}
---
Content-Type: application/json; charset=utf-8
Content-Length: 17
{"hasNext":false}
-----
I agree that the test should also check for the presence of the {"hasNext":false}
string part though! I created #85 for this.
from graphql-helix.
In any case, will have this behaviour verified with the working group, because I suspect it should flush hasNext: false on the "last" payload.
from graphql-helix.
@maraisr An AsyncGenerator can sometimes not determine whether a yielded item is the last item as it might need to make roundtrips to a database first. It would be kind of weird to block the publishing of the current value until the next value has been retrieved just to save some bandwidth caused by sending an additional {"hasNext":false}
payload over the wire.
from graphql-helix.
In any case, this is not a concern of graphql-helix as it just wraps graphql-js. So all your concerns are actually graphql-js related and should be raised on the graphql-js repository and be discussed in the working group.
from graphql-helix.
Related Issues (20)
- Avoid bundling GraphiQL HOT 3
- processRequest does not support multiple accept types HOT 2
- FastifyError: Promise may not be fulfilled with 'undefined' when statusCode is not 204 HOT 1
- Prohibiting SSE via POST breaks `graphql-sse` usage (since 1.11.0) HOT 6
- Fastify example - cannot set cookies HOT 5
- missing exports `send ... ResponseResult` from `node-http` in the barrel file
- Error: Cannot find module `<path>\node_module\graphql-helix\dist\dist.js` HOT 3
- Helix in Gateway to pass headers down to subschema? HOT 1
- graphql-ws example: Invalid query returns "Subscriptions should be sent over WebSocket" HOT 2
- Slow processRequest when error thrown HOT 1
- graphql-koa-example: subscriptions not working
- [Question] Have you thought about graphql-jit? HOT 2
- Adding `extensions` to `GraphQLParams`
- Is development dead? Zero commits since The Guild announced Yoga 2. HOT 1
- Infinite loop when using defer and async iterators (`JavaScript heap out of memory`)
- Can we detect/support cancelation of @stream operations?
- typescript compilation errors
- Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client HOT 1
- Before and after crud operation listeners
- Enabling CSP protection with koa + @koa/helmet causes 404 error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql-helix.