We are fragmenting too aggressively about contiki

[aguirrem]

I just noticed this too! I was trying to figure out what had changed.
Could the same be said for platforms that don't have crypto or have it disabled?

[aguirrem]

👍
I have tested the changes proposed here with good results

[adamdunkels]

Nice! Does anyone have a patch/pull request?

[g-oikonomou]

This was more like a bug report.

If the proposed change works it's only a fluke, it was off the top of my head

On 18 Nov 2013, at 06:23, Adam Dunkels [email protected] wrote:

Nice! Does anyone have a patch/pull request?

—
Reply to this email directly or view it on GitHub.

[aguirrem]

I am not very familiar with that part of the code or the reasons why it changed.
Can anyone shed into @g-oikonomou speculations above? I can put a pull request together if the fix is acceptable

[laurentderu]

MAC_MAX_PAYLOAD should be replaced by the maximum PHY frame size. There is one caveat though, if the framer appends bytes after the payload, they are not included in framer_hdrlen. In case of 802.15.4 the FCS is appended, so you have to replace MAC_MAX_PAYLOAD by 127 - 2. By doing that there is no need to use max(framer_hdrlen, 25)

ce99c02 from #557 fixes this as a side effect

Maybe a cleaner solution would be to add a function in framer to return the len of appended data.