Broken handling of skipContentModel in getFullSourceSpace about contentful-batch-libs

[Khaledgarbaya]

Hi @felixjung, the thing is some contentTypes may or may not have an editor interface. The bug here is that I forgot to set response.editorInterfaces to [] if the length is 0, I will push a fix right away

[Khaledgarbaya]

here is the commit : 35ee3f3

[felixjung]

Hm yeah, I understand that. My point was just that instead of having any if clause at all, you could just run the .map call anyway. In code, I think

.then((response) => {
  if (response.contentTypes.length !== 0) {
    response.editorInterfaces = getEditorInterfaces(response.contentTypes)
    return Promise.props(response)
  }
  response.editorInterfaces = []
  return response
})

and this

.then((response) => {
  response.editorInterfaces = getEditorInterfaces(response.contentTypes)
  return Promise.props(response)
})

are essentially the same, because the call to getEditorInterfaces() will return a promise resolving to an empty array when response.contentTypes is [], anyway. If I'm right, that would be cleaner, no?

[axe312ger]

@felixjung I agree with u but since we will refactor the logic in there in the near future and the actual bug was fixed in last December, I will close this ticket for now.

[iolloyd]

Is this still going to be addressed in 'the near future'?

[axe312ger]

Is this still going to be addressed in 'the near future'?

Yes. Can't be more precise because there are high priorities at the moment, but that's very much on top of the list.

What are you missing @iolloyd? We are (sadly) no superheroes, every PR is welcome :)