Couldn't get any output from runc commands about rust-extensions

[jiangliu]

We have introduced PipedStdIo to help the situation, https://github.com/containerd/rust-extensions/blob/main/crates/runc/src/io.rs#L250.
Will it help here?

[Burning1020]

We have introduced PipedStdIo to help the situation, https://github.com/containerd/rust-extensions/blob/main/crates/runc/src/io.rs#L250. Will it help here?

PipedStdIo helps. My point is in order to override it, every command options need a pub io: Option<Arc<dyn Io>> field member.

[jiangliu]

As we have provided both InheritedStdIo and PipedStdIo, it would be reasonable to make the most popular one as the default. And it's easy to override it when the default value doesn't work.

[Burning1020]

As you see in #37 (comment), stdout and stderr are empty in the returned error message.

2022-02-27T22:25:36.2249644Z     container_test.go:716: expected error "not found" but received "Others(\"Other: unknown error after kill: runc command failed: status=exit status: 1, stdout=\\\"\\\", stderr=\\\"\\\"\"): unknown"

The reason may be that they are deliverd to shim stdio and redirected to /dev/null.

[Burning1020]

1. Inherited StdIo will pass the stdout/stderr to parent process stdio.
2. Piped StdIo will pass them to parent process itself.

If first one is by default, we need add a io member in every command optios so as to deliver output to shim process itself instead of its stdio.