Coder Social home page Coder Social logo

Upgrade containerd api. about cri HOT 10 CLOSED

containerd avatar containerd commented on June 7, 2024 1
Upgrade containerd api.

from cri.

Comments (10)

crosbymichael avatar crosbymichael commented on June 7, 2024 1

Ya, we are doing our final API review so we have something consistent and good for the long term where its versioned as well. Sorry for the churn right now but its best to do this now, before a release, then later.

from cri.

mikebrow avatar mikebrow commented on June 7, 2024

A quick review of 1040 and 1047 they don't look like major changes just some renames.

from cri.

Random-Liu avatar Random-Liu commented on June 7, 2024

A quick review of 1040 and 1047 they don't look like major changes just some renames.

Yeah, shouldn't be too hard.
But without rename, cri-containerd won't work with new containerd because grpc requires both sides using the same package name. :)

from cri.

Random-Liu avatar Random-Liu commented on June 7, 2024

@crosbymichael Yeah, no worry. :)

Just track the api change here, so that when do rebase we have better ideas what need to be changed.

from cri.

crosbymichael avatar crosbymichael commented on June 7, 2024

When we cut the 1.0 alpha it would be a good time to rebase on it

from cri.

mikebrow avatar mikebrow commented on June 7, 2024

main changes:

  • rename execution->tasks (we'll need to throw out fake execution for a new fake tasks and events)
  • the mount package was moved to types
  • execution/task events are now implemented by a new events service
  • all services now have the /v1 suffix
  • containers.Container_Runtime struct replaced runtime string.. (new struct includes runtime options, something to consider as we move forward)

from cri.

Random-Liu avatar Random-Liu commented on June 7, 2024

@mikebrow Thanks! We could keep updating here, so as to make our future rebase easier.

from cri.

crosbymichael avatar crosbymichael commented on June 7, 2024

We still have 1-2 API level changes to make before cutting the Alpha. I'll let you know when we do.

from cri.

mikebrow avatar mikebrow commented on June 7, 2024

Work in progress synching up to the containerd/containerd current master commit 4888d40ac7ca94b914c5f37c1f8129eab2df3790

from cri.

mikebrow avatar mikebrow commented on June 7, 2024

Moving to the latest commit to pick up some more client apis
4118a256e9f17199ed2ab647fad6946cc59fcd81

from cri.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.