illegal instruction? about spacy-feedstock

[rmax]

Hi, thanks for the report!

For reference, this is the feedstock build log: https://circleci.com/gh/conda-forge/spacy-feedstock/81

Maybe it's related to the -march=native flag. From my little search, it seems the flags for a portable build are -march=x86-64 -mtune=generic.

The question is where the fix should go, either spacy's setup.py or a recipe patch.

@jakirkham @honnibal any thoughts?

[jakirkham]

Sorry. Just now saw this.

Yeah -march=native is probably a bad idea. The CIs may not be on the latest and greatest architecture, but they may be more advanced then most machines. So would not be surprised if it ran unsupported instructions.

Typically one wants -march=<something really old> and -mtune=generic. Our plan with the new compilers is similar. We picked -march=nocona, which is more than a decade old (should be safe). Though it seems we didn't choose -mtune=generic, which I'm following up on.

ref: https://paper.dropbox.com/doc/Compiler-meeting-20171116-1lYaDIP93JRzzQZBlicxg

[lopusz]

Dear SpaCy Team, Dear @rmax,

I am sorry for being a bit unresponsive :(

Spacy 2.0.4 works fine on both machines I tested. Thank you for the fix!

I do not know how about comment of @jakirkham. So I am not closing the issue.
However, for me it is solved.

Best regards,
Michał

[rmax]

@lopusz Could you confirm if the release 2.0.3 fixes your issue?