Comments (9)
Oh, I'm really sorry to hear that. I'm out for the week so I think it would be best to revert the changes until then. I will take a closer look at the issues when I'm back. I must have done something wrong, sorry!
from sparqlee.
A does the mentioned commit work? It seems like it's the commit where we introduced the new cache. Maybe I needed to add this module dependency somewhere and didn't?
from sparqlee.
No, that one doesn't work. I'll just revert (as I have to prepare a new release ASAP)
from sparqlee.
With even more pain in my hearth I suggest rolling back further than this then, to the commit before we touched the type system since the new type system without a cache is way to slow.
from sparqlee.
Up until what commit would you suggest then?
from sparqlee.
Since I'm one my phone it's pretty hard to get the reference but here #112 (comment) I mentioned a few commits, the commit with lowest execution time is the one we want. This is where we introduced the overloadTree but didn't touch the type system.
from sparqlee.
I think it was this commit jitsedesmet@c4959d6. Again, I'm really sorry for all this.
from sparqlee.
Ah yeah, that's the one I was referring to in the issue description :-)
So I'll just revert to right before that one.
from sparqlee.
HEAD state at the time of writing is now in https://github.com/comunica/sparqlee/commits/reverted/jitse, and master has been reverted.
from sparqlee.
Related Issues (20)
- Suport overriding functions HOT 12
- AggregateEvaluators is a mess HOT 4
- Migrate to eslint HOT 1
- Enable `no-redeclare` rule HOT 52
- Enable `no-implicit-globals` rule HOT 3
- Auto casting arguments using `OverloadTree` HOT 26
- Document spec link explaining `arithmeticWidening` HOT 1
- Clean NumericLiterals specificFormatterCreator HOT 1
- OverloadTree caching and open world types HOT 2
- Async super type discovery and getting full context in regular functions. HOT 1
- Wrong implementation of substr HOT 3
- Handle invalid lexical form better HOT 6
- Make new type system default HOT 1
- Dependency Dashboard
- Include Sparqlee into the main Comunica monorepo HOT 15
- DISTINCT is not supported yet on aggregates
- `month` function not erroring on invalid dates HOT 1
- Equality check Error should not be thrown
- Refactor out redundancies in RegularFunctions and Ordering HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sparqlee.