Coder Social home page Coder Social logo

Breaking changes about sparqlee HOT 9 CLOSED

rubensworks avatar rubensworks commented on June 11, 2024
Breaking changes

from sparqlee.

Comments (9)

jitsedesmet avatar jitsedesmet commented on June 11, 2024

Oh, I'm really sorry to hear that. I'm out for the week so I think it would be best to revert the changes until then. I will take a closer look at the issues when I'm back. I must have done something wrong, sorry!

from sparqlee.

jitsedesmet avatar jitsedesmet commented on June 11, 2024

A does the mentioned commit work? It seems like it's the commit where we introduced the new cache. Maybe I needed to add this module dependency somewhere and didn't?

from sparqlee.

rubensworks avatar rubensworks commented on June 11, 2024

No, that one doesn't work. I'll just revert (as I have to prepare a new release ASAP)

from sparqlee.

jitsedesmet avatar jitsedesmet commented on June 11, 2024

With even more pain in my hearth I suggest rolling back further than this then, to the commit before we touched the type system since the new type system without a cache is way to slow.

from sparqlee.

rubensworks avatar rubensworks commented on June 11, 2024

Up until what commit would you suggest then?

from sparqlee.

jitsedesmet avatar jitsedesmet commented on June 11, 2024

Since I'm one my phone it's pretty hard to get the reference but here #112 (comment) I mentioned a few commits, the commit with lowest execution time is the one we want. This is where we introduced the overloadTree but didn't touch the type system.

from sparqlee.

jitsedesmet avatar jitsedesmet commented on June 11, 2024

I think it was this commit jitsedesmet@c4959d6. Again, I'm really sorry for all this.

from sparqlee.

rubensworks avatar rubensworks commented on June 11, 2024

Ah yeah, that's the one I was referring to in the issue description :-)
So I'll just revert to right before that one.

from sparqlee.

rubensworks avatar rubensworks commented on June 11, 2024

HEAD state at the time of writing is now in https://github.com/comunica/sparqlee/commits/reverted/jitse, and master has been reverted.

from sparqlee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.