Comments (5)
Thanks for reporting!
from comunica.
I would suggest also replacing the following with it.emit('error', error); it.close()
:
-
At the same time I suggest tests be added to make sure that the streams can be consumed when necessary in error scenarios.
from comunica.
Note that AsyncIterator.destroy()
was introduced to handle exactly these cases.
So if it doesn't do what we want it to do, then this is a design error in AsyncIterator.
The replacement you suggest is not the proper solution I believe, as calling .close()
will still attempt to flush any buffered contents, while we can stop earlier (which is what .destroy()
provides).
from comunica.
@jeswr Now that comunica/comunica-feature-link-traversal#95 has been resolved, ok to close this issue?
from comunica.
Closing this one. Feel free to re-open if still relevant in the future.
from comunica.
Related Issues (20)
- Support VoID descriptions in SPARQL endpoints HOT 1
- Query with multiple `COUNT` clauses returns incorrect result depending on order in projection HOT 4
- is GROUP_CONCAT supported by comunica? HOT 2
- Optional keyword does not seem to work HOT 7
- Inserting at non-existing resource throws in V3 HOT 5
- SPARQL query fuzzing HOT 1
- CONSTRUCT with LIMIT broken in Comunica 3.0.1 HOT 2
- How to bundle with Webpack HOT 8
- CONSTRUCT query with BIND or VALUES does not work as expected on a Solid pod HOT 3
- Multi-source traversal yields zero results HOT 4
- Use `#cancel()` where possible. HOT 2
- Blank nodes in update queries do not match arbitrary nodes HOT 5
- Stats writer produces wrong totals HOT 4
- [mver]: Replace `Readable` signatures with `AsyncIterator` HOT 2
- Adding a new Bus HOT 2
- Test bug HOT 1
- Test bug 2
- Test bug 3 HOT 1
- Test bug 4 HOT 1
- Test bug 5 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from comunica.