Comments (2)
I think this is a bug introduced while I was cleaning up the code to release. It seems like the albedo harmonization network isn't giving the same output I was getting when I made that figure. I'll try to do some testing and see if I can figure out what's going wrong. I'll let you know when things are working.
Thanks!
from intrinsiccompositing.
I've found two discrepancies between the GitHub codebase and the original codebase used for the paper. The first discrepancy was a trivial mask pre-processing error when performing albedo harmonization. After fixing this bug, the result for this example looks like this:
The second discrepancy is actually a bug in the original implementation I used to generate figures for the paper. The original albedo harmonization training and testing code assumed that the shading images were stored as 16-bit values, and normalized them to [0-1] accordingly. But when generating results I was using 8-bit shading images. This meant that the albedo being fed to the network was incorrect (due to the low-contrast shading values). When I prepared the code for release, I fixed this bug without thinking about it meaning the GitHub code does not have this issue. I believe the GitHub code is a more accurate implementation since the albedo harmonization network is receiving the correct albedo as input. In order to maintain reproducibility, I've added a flag to the inference script called --reproduce_paper
that will use the logic and weights from the original implementation (10edf3b). Without this flag, the code will run correctly and use better weights for the reshading network. Here are the results you should see for each setting of this flag:
with --reproduce_paper |
without --reproduce_paper |
---|---|
The same flag has been added the interface. I'll add a note to the README explaining this as well. Thank you for bringing this to my attention!
from intrinsiccompositing.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from intrinsiccompositing.