Comments (5)
Hey @gursharan001 . Sorry for the slow response. Yes, I would definitely support adding this functionality. Happy to help in terms of API design etc.. I'm sure @ninjarobot would be happy as well to lend some advice.
from farmer.
Thanks @isaacabraham @ninjarobot
I thought API could be something like below
type ActiveDirectoryPrincipalType = User | Group
type ActiveDirectoryAdminSettings =
{
/// Active Directory name of user or group
Login: string
/// Active Directory object id of user or group
Sid: string
PrincipalType: ActiveDirectoryPrincipalType
AdOnlyAuth: bool
}
and then Farmers.Builders.SqlAzure.SqlAzureConfig
updated as
type SqlAzureConfig =
{
Name: SqlAccountName
AdministratorCredentials: {| UserName: string
Password: SecureParameter |}
/// new setting
ActiveDirectoryAdmin: ActiveDirectoryAdminSettings option
MinTlsVersion: TlsVersion option
FirewallRules: {| Name: ResourceName
Start: IPAddress
End: IPAddress |} list
ElasticPoolSettings: {| Name: ResourceName option
Sku: PoolSku
PerDbLimits: {| Min: int<DTU>; Max: int<DTU> |} option
Capacity: int<Mb> option |}
Databases: SqlAzureDbConfig list
GeoReplicaServer: GeoReplicationSettings option
Tags: Map<string, string>
}
for scenario when AdOnlyAuth
is true
, Farmers.Builders.SqlAzure.SqlServerBuilder.Run
might raise an error or silently ignore the password if provided. I prefer raising an error.
What are your thoughts?
from farmer.
@gursharan001 thanks for the proposal. The config structure looks good - do you know if both the SID and the login name are required or can either work?
As far as the password, it's a SecureParameter
and Farmer can control whether to emit a parameter for it, so I suggest that when AdOnlyAuth
is set to true, just don't emit one.
from farmer.
@ninjarobot yes both SID and login are required. I will submit a PR soon. Thanks!
from farmer.
@isaacabraham / @ninjarobot , please review the PR when you get a chance
from farmer.
Related Issues (20)
- Refresh token has expired HOT 2
- Support for autoscaling configurations
- Need more property settings in Virtual Network HOT 4
- Add support for creating application security groups and adding them to the NSG.
- Support for adding an ASG rule to a VM interface. HOT 1
- Add option to set DAPR protocol for Container Apps HOT 1
- Event Hub as dependency is invalid HOT 4
- Get existing project running
- Seems as if remote vnet peering for virtual networks does not support the remote vnet being in a different resource group HOT 1
- Deploying a function app overwrites the WEBSITE_CONTENTSHARE value HOT 1
- SQL Server Builder - Create System Assigned Identity HOT 3
- CosmosDB Gremlin support HOT 3
- P0V3 app service type is missing
- Add SupportsHttpsTrafficOnly property support for storage accounts
- Tests failing in CICD HOT 2
- Service Bus builder needs validation improvements
- Alert dependable on Action Group HOT 2
- App Service does not support Linux App Insights automatic instrumentation
- Upgrade to Fantomas 6
- No builder support for adding subnet per IP of LoadBalancer backendAddressPool
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from farmer.