ambiguous column names via build_count_subquery about composite_primary_keys

[cfis]

Hi cleesmith,

Thanks for reporting the issue. Definitely would be better to not have to convert the cpk to a string to then parse it. If you have time, would be good to set this up in the test suite so we can have a test for it. I don't think any of the tables have the set of primary keys, but its worth a look. If not, maybe we should add one.

[cleesmith]

I don't have time this week or next, but I am using my fork of cpk in a project working with the Snort legacy database where almost every table has both of those primary keys.

Also, when I run the tests for MySQL I get a few errors ... it would be nice to start off cleanly, not complaining, just FYI:

rake mysql:build_databases
rake mysql:test
 . . .
105 tests, 266 assertions, 5 failures, 1 errors, 0 skips

  1) Error:
test_has_many_through_when_not_pre_loaded(TestAssociations):
ActiveRecord::StatementInvalid: Mysql::Error: 
Duplicate column name 'dorm_id': 
SELECT COUNT(*) FROM (SELECT DISTINCT * FROM `rooms` 
INNER JOIN `room_assignments` 
ON `rooms`.`dorm_id` = `room_assignments`.`dorm_id` 
AND `rooms`.`room_id` = `room_assignments`.`room_id` 
WHERE `room_assignments`.`student_id` = 1) subquery_for_count

  2) Failure:
test_to_key_with_composite_keys_unsaved(TestAttributeMethods) [/Sites/composite_primary_keys/test/test_attribute_methods.rb:39]:
Expected [0, nil] to be nil.

  3) Failure:
test_and(TestEqual) [/Sites/composite_primary_keys/test/test_predicates.rb:32]:
<"\"departments\".\"id\" = 0 AND \"departments\".\"id\" = 1 AND \"departments\".\"id\" = 2"> expected 
but was <"`departments`.`id` = 0 AND `departments`.`id` = 1 AND `departments`.`id` = 2">.

  4) Failure:
test_or(TestEqual) [/Sites/composite_primary_keys/test/test_predicates.rb:18]:
<"((\"departments\".\"id\" = 0) OR (\"departments\".\"id\" = 1) OR (\"departments\".\"id\" = 2))"> expected 
but was <"((`departments`.`id` = 0) OR (`departments`.`id` = 1) OR (`departments`.`id` = 2))">.

  5) Failure:
test_not_found(TestFind) [/Sites/composite_primary_keys/test/test_find.rb:53]:
<"Couldn't find ReferenceCode with ID=999,999 WHERE \"reference_codes\".\"reference_type_id\" = 999 AND \"reference_codes\".\"reference_code\" = 999"> expected 
but was
<"Couldn't find ReferenceCode with ID=999,999 WHERE `reference_codes`.`reference_type_id` = 999 AND `reference_codes`.`reference_code` = 999">.

  6) Failure:
test_assign_ids(TestIds) [/Sites/composite_primary_keys/test/test_ids.rb:86]:
<[nil, nil]> expected but was
<[0, nil]>.

Also, there is an error and some deprecation warnings (activerecord 3.2.0?):

Using native MySQL
DEPRECATION WARNING: Calling set_primary_key is deprecated. Please use `self.primary_key = 'the_name'` instead. (called from set_primary_keys at /Users/cleesmith/Sites/composite_primary_keys/lib/composite_primary_keys/base.rb:14)
DEPRECATION WARNING: Calling set_primary_key is deprecated. Please use `self.primary_key = 'the_name'` instead. (called from <class:ReferenceType> at /Users/cleesmith/Sites/composite_primary_keys/test/fixtures/reference_type.rb:2)

Unable to load restaurants_suburb, underlying cause No such file to load -- restaurants_suburb 

. . . but I can't find the reference, but I think that should be restaurants_suburbs instead.

I will look at the tests to see if I can find something similar to the Snort situation.
Thanks.

[cfis]

Great - thanks. Do you see failiures on Rails 3.1? Wondering if these are new errors for Rails 3.2 that need solving.

[cleesmith]

Which version of cpk would I need to download to test with Rails 3.1, as doing a git clone is 3.2.0 specific ?

[cfis]

The 4.x series. Or in git, look at the ar_3.1x branch.

[cfis]

Ok, fixed in master adedcf8, will be in next release. Thanks for finding this bug.

Charlie

[cleesmith]

Thank you very much. I'm sorry I couldn't have been of more help with this issue ... I will try to better open source citizen in the future.

[cfis]

FYI, MySql tests now all pass also.

[cleesmith]

Cool, thanks again.

[cfis]

No worries - thanks for submitting the bug. New Gem just uploaded to rubygems.org. Give it a try - hope it works!

Charlie

[cleesmith]

Just tried the new cpk gem release with the legacy db project I've been working on and it works great! Thanks, again.