Coder Social home page Coder Social logo

Comments (3)

Seldaek avatar Seldaek commented on May 31, 2024

Ok so it would be somthing like adding logs if is_readable fails in

ca-bundle/src/CaBundle.php

Lines 340 to 352 in 9fdb22c

private static function caFileUsable($certFile, LoggerInterface $logger = null)
{
return $certFile && @is_file($certFile) && @is_readable($certFile) && static::validateCaFile($certFile, $logger);
}
/**
* @param string|false $certDir
* @return bool
*/
private static function caDirUsable($certDir)
{
return $certDir && @is_dir($certDir) && @is_readable($certDir) && glob($certDir . '/*');
}
or perhaps also if the glob() fails for dirs. Would that be enough?

from ca-bundle.

STotev avatar STotev commented on May 31, 2024

@Seldaek yes, I think this should be enough. I could create a PR but wasn't sure what the decision for that might be. Should it be just debug logs or should it throw an exception? Since unreadable or inexistent certificates are essentially invalid, should that stop composer from continuing? Although this is probably a question for the Composer itself.

from ca-bundle.

Seldaek avatar Seldaek commented on May 31, 2024

I think just debug logs so if you run composer with -vvv you get a chance to see those warnings. I see no reason to abort due to an unreadable one if an alternative usable CA file can be found.

from ca-bundle.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.