Servo code missing original copyright about arduinocore-gd32

[michaelmargolis]

thanks and have fun with the project Michael

…

________________________________ From: Maximilian Gerhardt ***@***.***> Sent: 05 August 2021 19:50 To: CommunityGD32Cores/ArduinoCore-GD32 ***@***.***> Cc: Michael Margolis ***@***.***>; Author ***@***.***> Subject: Re: [CommunityGD32Cores/ArduinoCore-GD32] Servo code missing original copyright (#30) All done already, see above commit references. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#30 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAENQYTLLZ3NWVYXLX7NLYLT3LMPXANCNFSM5BUL6HAA>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.

[maxgerhardt]

The servo class implementation can impossibly be from the AVR core because it uses HardwareTimer, that doesn't exist in the AVR core.

ArduinoCore-GD32/libraries/Servo/src/Servo.cpp

Lines 1 to 4 in 2f1adfb

	#include <Arduino.h>
	#include <Servo.h>
	#include "HardwareTimer.h"

I'll review the header more closely.

[maxgerhardt]

The header seems to be mostly from

https://github.com/arduino-libraries/Servo/blob/f3617664917ff1a46c2c3db5300d27054ba147cc/src/Servo.h#L80-L122

that is correct. Will add.

[maxgerhardt]

Resolved in a68917a, 2b34964, ca0173f and 50134d9

[michaelmargolis]

Thank you for your prompt reply. Although the interrupt code is different, the Servo class appears identical. In this case you can add the copyright of the author of interrupt code to the original copyright. Michael Margolis (author of the servo code) Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10 From: Maximilian ***@***.***> Sent: 05 August 2021 19:19 To: ***@***.***> Cc: Michael ***@***.***>; ***@***.***> Subject: Re: [CommunityGD32Cores/ArduinoCore-GD32] Servo code missing original copyright (#30) The servo class can impossibly be from the AVR core because it uses HardwareTimer, that doesn't exist in the AVR core. https://github.com/CommunityGD32Cores/ArduinoCore-GD32/blob/2f1adfb0d687db72b0598ea3c3bbf217a0446ce5/libraries/Servo/src/Servo.cpp#L1-L4 I'll review the header more closely. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#30 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAENQYWMXAXQOJAPME2CWMDT3LI4NANCNFSM5BUL6HAA>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.

[maxgerhardt]

All done already, see above commit references.