Coder Social home page Coder Social logo

Comments (15)

kentcdodds avatar kentcdodds commented on July 20, 2024

I'm confused. The latest version in master's package.json states it's version 1.1.0, but the latest version on npm is 1.1.2, and the tag on github has a package.json with 1.1.2 and was released just 2 weeks ago but doesn't have the fix in it which happened 3 weeks ago...

What kind of operation are you running here Jim!? :P

from cz-conventional-changelog.

kentcdodds avatar kentcdodds commented on July 20, 2024

I'll tell you what. I'll set up semantic-release and publish-latest on this repo, then everything will be better.

from cz-conventional-changelog.

kentcdodds avatar kentcdodds commented on July 20, 2024

Hey @jimthedev, could you add @commtizen-bot to the owners on the org and https://www.npmjs.com/~commitizen-bot to the collaborators on npm? Thanks!

from cz-conventional-changelog.

kentcdodds avatar kentcdodds commented on July 20, 2024

Forget about npm, I got that working. Just need to add @commitizen-bot to the org. Thanks!

from cz-conventional-changelog.

jimthedev avatar jimthedev commented on July 20, 2024

Hey, sorry Kent. I've been sick on and off for the past month so I'm a bit behind and clearly missed something here. Thanks for catching it.

Here is a quick update:

  • Commitizen-bot has been added on npm
  • I want to implement all of the changes you talk about in your library egghead series.
  • I've started a complete rewrite of cz-cli including a full test suite. It is slow going but includes the ability to run commitizen init which will npm install the adapter and edit package.json to include the dependency.
  • The version in package.json of this adapter is obviously wrong. My guess is I missed a push.

Thanks for lending a hand. :)

from cz-conventional-changelog.

kentcdodds avatar kentcdodds commented on July 20, 2024

That all sounds amazingly awesome. Could you add the @commitizen-bot account to the github org so it can push tagged releases?

from cz-conventional-changelog.

jimthedev avatar jimthedev commented on July 20, 2024

Invite sent!

from cz-conventional-changelog.

kentcdodds avatar kentcdodds commented on July 20, 2024

It was a bit bumpy, but everything's set now! @commitizen-bot is at our command :-)

from cz-conventional-changelog.

kentcdodds avatar kentcdodds commented on July 20, 2024

Unfortunately, I'm still getting this error when using this with angular-formly :-(

Potentially unhandled rejection [3] Error: Error loading "word-wrap" at file:/Users/kentcdodds/Developer/formly-js/angular-formly/node_modules/cz-conventional-changelog/word-wrap.js
Error loading "word-wrap" from "index" at file:/Users/kentcdodds/Developer/formly-js/angular-formly/node_modules/cz-conventional-changelog/index.js
ENOENT: no such file or directory, open '/Users/kentcdodds/Developer/formly-js/angular-formly/node_modules/cz-conventional-changelog/word-wrap.js'
at Error (native)

No idea what's up... I'm using npm@3...

from cz-conventional-changelog.

jimthedev avatar jimthedev commented on July 20, 2024

It is npm3. It moves around packages which unfortunately breaks some of the assumptions that cz makes about the filesystem. I am working on a fix that takes this into account as part of 2.0 which includes a CI test suite.

from cz-conventional-changelog.

jimthedev avatar jimthedev commented on July 20, 2024

2.0 is also written in ES6 w/ Babel so you'll be right at home @kentcdodds

from cz-conventional-changelog.

kentcdodds avatar kentcdodds commented on July 20, 2024

Awesome! I recommend you checkout the way add-to-path is built and released. Writing your stuff in ES6 is awesome, automatically building and releasing it is even cooler! Just check out the scripts and the .travis.yml

from cz-conventional-changelog.

jimthedev avatar jimthedev commented on July 20, 2024

Sounds good @kentcdodds. I expect it to be ready for review in the next few days or so. Once I get all of that integrated would you be willing to do a final review?

from cz-conventional-changelog.

kentcdodds avatar kentcdodds commented on July 20, 2024

Sure!

from cz-conventional-changelog.

jimthedev avatar jimthedev commented on July 20, 2024

high five gang

from cz-conventional-changelog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.