Allow Groups to have clearly defined inputs and outputs about comfyui

[allo-]

I think you are just saying it in a different way. The subgraphs in nodes is exactly what I want, but its UI is inconvenient for further editing. One would need a new UI, not now nodes.

What I should have added in the graphic above is that of course each input can be connected to multiple nodes within the group. If I have a subgraph that uses, let's say, Checkpoint and VAE three times for upscaling, I have six connections. If I need that subgraph a second time, I have twelve connections and it gets hard to organise things.

With a group UI like the one sketched, I would have six connections inside each group, but only two on the outside, keeping the complexity inside the group. Such a group could also be collapsed (into a subgraph node) to hide the complexity completely, so the user doesn't even need to know that the two inputs are branched to connect to three different nodes.

[asagi4]

I think this should just be a feature of graphs instead of groups (notably including the top level graph). Then, all you need to do is improve the subgraph implementation that is already there (they're just really annoying to edit at the moment) and get much more flexibility.

[allo-]

I'm not sure what you mean by graphs, maybe we mean the same thing.

I think visually of a box where I can place inputs and outputs on the edges. Then I put nodes and their connections inside, technically a (sub)graph, cut all connections to the outside and connect them to the inputs and outputs on the edge of the box. Now I have a reusable meta-node that can be used in normal workflows (similar to group nodes) but makes transparent what is happening inside.

[allo-]

I imagine it to look like this

Technically, the inputs and outputs at the boundary would be similar to reroute nodes and in the UI they could be rendered similar to the inputs and outputs at nodes.

[asagi4]

Graphs are just what ComfyUI workflows are, and what group nodes are. Basically I don't think it makes sense to add inputs to groups when you already have the node abstraction for that; all you need to do is make subgraphs into nodes (already implemented) and make using them convenient (which is missing).

In short, I agree with having explicit inputs and outputs, they should just be a part of graphs, not a feature of groups.