Comments (5)
I think you are just saying it in a different way. The subgraphs in nodes is exactly what I want, but its UI is inconvenient for further editing. One would need a new UI, not now nodes.
What I should have added in the graphic above is that of course each input can be connected to multiple nodes within the group. If I have a subgraph that uses, let's say, Checkpoint and VAE three times for upscaling, I have six connections. If I need that subgraph a second time, I have twelve connections and it gets hard to organise things.
With a group UI like the one sketched, I would have six connections inside each group, but only two on the outside, keeping the complexity inside the group. Such a group could also be collapsed (into a subgraph node) to hide the complexity completely, so the user doesn't even need to know that the two inputs are branched to connect to three different nodes.
from comfyui.
I think this should just be a feature of graphs instead of groups (notably including the top level graph). Then, all you need to do is improve the subgraph implementation that is already there (they're just really annoying to edit at the moment) and get much more flexibility.
from comfyui.
I'm not sure what you mean by graphs, maybe we mean the same thing.
I think visually of a box where I can place inputs and outputs on the edges. Then I put nodes and their connections inside, technically a (sub)graph, cut all connections to the outside and connect them to the inputs and outputs on the edge of the box. Now I have a reusable meta-node that can be used in normal workflows (similar to group nodes) but makes transparent what is happening inside.
from comfyui.
I imagine it to look like this
Technically, the inputs and outputs at the boundary would be similar to reroute nodes and in the UI they could be rendered similar to the inputs and outputs at nodes.
from comfyui.
Graphs are just what ComfyUI workflows are, and what group nodes are. Basically I don't think it makes sense to add inputs to groups when you already have the node abstraction for that; all you need to do is make subgraphs into nodes (already implemented) and make using them convenient (which is missing).
In short, I agree with having explicit inputs and outputs, they should just be a part of graphs, not a feature of groups.
from comfyui.
Related Issues (20)
- Node Development Test Environment HOT 1
- How i to do int to float Node (can link value from other node) HOT 1
- Error occurred when executing SamplerCustom HOT 1
- Error occurred when executing CLIPTextEncode HOT 2
- free_memory is not work HOT 7
- ComfyUI started but the page crashes the browser HOT 6
- New Search Function Seems to Not Work HOT 2
- ClipTextEncoderFlux not separating keys out in a usable form HOT 1
- when i update comfyui,i cannot use it anymore HOT 2
- Node Search Box not working with custom nodes HOT 2
- Extremely slow to load Flux FP8, after updated to pytorch 2.4.0+cu124, UserWarning: 1Torch was not compiled with flash attention HOT 5
- Hyper-FLUX Guider_Basic error
- [ feature ] add more options to Flux ( from changes during development )
- Persist more settings in workflow.json backup files
- CUDA Malloc blacklist not working correclty
- InstantX Canny ControlNet - KSampler error ( mat1 and mat2 shapes cannot be multiplied ) HOT 2
- Organize the chaotic node selection
- Safari browser can't unlock a group once locked HOT 1
- The flux dev model outputs pure black on 4090 HOT 3
- Slow generation times in Flux, using loras ( fixed by using GGUF models or XLabs loras ) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from comfyui.