Access public methods from a dataobject on GET request? about silverstripe-restfulapi

[colymba]

onBeforeSerialize would be the right place for those kind of cases. If you have it defined on a DataExtension, you should have something like that:

public function onBeforeSerialize()
{
    $this->owner->FullName = $this->owner->fullname();
}

that will create a property FullName on your dataobject that will be serialized with the rest as the DB fields like normal.

[mirkonz]

Awesome, thanks. I will give it a go tonight.

[mirkonz]

Hmm, I'm still struggling to get this to work.

class Student extends DataObject {
  private static $db = array(
    'firstname' => 'Varchar',
    'lastname' => 'Varchar'
  );
  public static $allowed_actions = array(
    'fullname'
  );
  public function onBeforeSerialize() {
    // This works:
    // Debug::show($this->owner-> fullname());

    // This doesn't work:
    $this->owner-> FullName = $this->owner-> fullname();
    // unset($this->owner->firstname);
  }
}
class StudentExtension extends DataExtension {
  public function fullname() {
    return $this->firstname . ' ' . $this->lastname;
  }
}

_config.php
Edited:

Student::add_extension('StudentExtension');

I also tried to put the onBeforeSerialize method on the DataExtension.

Is there more configuration required in the config.yml file?

[colymba]

$this->owner only work if you are in the DataExtension.
Then your config should read: Student::add_extension('StudentExtension');

So with this, you should have:

class Student extends DataObject {
  private static $db = array(
    'firstname' => 'Varchar',
    'lastname' => 'Varchar'
  }
  public static $allowed_actions = array(
    'fullname'
  ); 
  public function fullname() {
    return $this->firstname . ' ' . $this->lastname;
  }
}

class StudentExtension extends DataExtension { 
 public function onBeforeSerialize() {   
    $this->owner->FullName = $this->owner-> fullname();
    // unset($this->owner->firstname);
  }
}

[mirkonz]

That's not working for me.
This is how my response looks like:
{"students":[{"id":1,"firstname":"John","lastname":"Doe"}]}

Sorry, I made a mistake in my previews comment. I actually had Student::add_extension('StudentExtension') in my config, as well as $this->owner

[colymba]

So sorry, that's my bad. This used to work in earlier releases but now the serializer uses the Config api, so updating properties on the DataObject wont work that simply. You would have to update the static $db:

class StudentExtension extends DataExtension { 
 public function onBeforeSerialize() { 
    $db = $this->owner->config()->get('db');
    $db['fullName'] = '';
    $this->owner->config()->update('db', $db);  
    $this->owner->setField('fullName', $this->owner->fullname());
  }
}

Which I'll admit feels very awkward... and I can't really test this right now...

Best option might be the onAfterSerialize which works something like:

 public function onAfterSerialize(&$formattedDataObjectMap) { 
    $formattedDataObjectMap['fullName'] = $this->owner->fullname();
  }

[mirkonz]

That works perfectly!
Thank you so much for your time.

[colymba]

Tracking doc updates here #27