DataObject creation fails when DO has validation method about silverstripe-restfulapi

[colymba]

I guess it should be possible to skip the write() in the createModel. Might take a little re-writting, but have you tried passing the new DO directly to updateModel and see if that work?

[axyr]

That won't work, since that requires an ID, which is fine IMHO.

This is seems to work, but I think we should return the DO validation exeption in the response when it failes to write as well.

Not heavily tested:

function createModel($model, SS_HTTPRequest $request)
{
$payload = $this->deSerializer->deserialize( $request->getBody() );
if ( $payload instanceof RESTfulAPI_Error )
{
return $payload;
}
$newModel = Injector::inst()->create($model, $payload);
$newModel->write();
return $this->updateModel($model, $newModel->ID, $request);
}

[axyr]

This example catches the validation error:

function createModel($model, SS_HTTPRequest $request)
{
$payload = $this->deSerializer->deserialize( $request->getBody() );
if ( $payload instanceof RESTfulAPI_Error )
{
return $payload;
}

$newModel = Injector::inst()->create($model, $payload);

try {
    $newModel->write();
    return $this->updateModel($model, $newModel->ID, $request);
}catch(Exception $e) {
    $result = $e->getResult();
    return new RESTfulAPI_Error(400, $result->message());
}

}