leaving the "Find What" and "Replace With" field blank results in error about collective.searchandreplace

[mauritsvanrees]

I have released 8.1.1. Thanks!

[spereverde]

I added a check for rtext in this commit: spereverde@77df79e
That fixes the replacing with an empty 'replace with' field, but I'm not sure it is the cleanest way to fix it.
If you think it's acceptable, I can make a PR.

[spereverde]

I also found a way to make the form not fail when a user does not fill in the findWhat field:
spereverde@96ac0be
It will then go back to the form indicating that the findWhat field is required.
Again not sure if it's the best way to fix it, if acceptable I'll make a PR

[mauritsvanrees]

I have not tried it, but both fixes seem okay at first glance. A PR would be welcome.
Adding tests that fail without these fixes would be a nice bonus, but I realise tests can be tricky.

[spereverde]

Thanks for having a look! I discussed also with @gotcha, one test was already added in my fork, I will try to add the other one as well. I will make a couple of PR’s for the fixes, you will see them coming next week hopefully. From: Maurits van Rees <[email protected]> Reply to: "collective/collective.searchandreplace" <[email protected]> Date: Thursday, 10 December 2020 at 23:48 To: "collective/collective.searchandreplace" <[email protected]> Cc: Kim Paulissen <[email protected]>, Author <[email protected]> Subject: Re: [collective/collective.searchandreplace] leaving the "Find What" and "Replace With" field blank results in error (#43) I have not tried it, but both fixes seem okay at first glance. A PR would be welcome. Adding tests that fail without these fixes would be a nice bonus, but I realise tests can be tricky. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#43 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAIQ3BYSLBDXIRQ2XYBAPA3SUFF2FANCNFSM4UHK6UWQ>. [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "#43 (comment)", "url": "#43 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

[mauritsvanrees]

I have merged all your pull requests. Thanks for the improvements!
I can do a release. But maybe it is good if you check that all is well now?

[spereverde]

Thank you for all the fixes, approvals and merging :)
I will test it on our setup again to be sure and let you know asap
A release would be great then!

[spereverde]

Just did several tests in different setups and all seems to be working fine!
So a release would be greatly appreciated :-)
Thanks again!