Coder Social home page Coder Social logo

Panic on empty volume name about ntfs HOT 2 CLOSED

colinfinck avatar colinfinck commented on May 26, 2024
Panic on empty volume name

from ntfs.

Comments (2)

ColinFinck avatar ColinFinck commented on May 26, 2024

Thanks a lot for your report and the additional comment in #10 (comment)!
I finally realized that these were actually two bugs:

  • NtfsVolumeName must support empty strings as volume names. I previously only encountered filesystems that removed the entire $VOLUME_NAME attribute when the volume name was cleared. But apparently, this is not guaranteed.
  • data_position must also return a position when stream_position equals the value length. This happens when we seek to the very end of a value, but also when the value is zero-sized.

Both bugs have been fixed in 61d13c6 and a063e4a.

Note that $VOLUME_NAME is always a resident attribute. The Data Runs concept only applies to non-resident attributes, hence this bug needs to be clearly separated from #10.

from ntfs.

leofidus avatar leofidus commented on May 26, 2024

I can confirm that it works now. After your commits I get an empty string as volume name, as expected. Thanks.

from ntfs.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.